Re: [Rt2400-devel] rt2x00: cleanup Kconfig help

[Filipus Klutiero <chealer@gmail.com>]

Le April 14, 2008 07:33:32 am Ivo van Doorn, vous avez =E9crit=A0:
> > > >  	  When compiled as a module, this driver will be called
> > > > "rt2500usb.ko".
> > > >
> > > >  config RT73USB
> > > > -	tristate "Ralink rt73 usb support"
> > > > +	tristate "Ralink RT2571W and RT2671 (USB) support"
> > > >  	depends on RT2X00 && USB
> > > >  	select RT2X00_LIB_USB
> > > >  	select RT2X00_LIB_FIRMWARE
> > > >  	---help---
> > > > -	  This is an experimental driver for the Ralink rt73 wireless=
 chip.
> > > > +	  This is an experimental driver for the RT2571W and RT2671 M=
AC/BBP
> > > > chips. It supports Ralink RT2501USB and RT5201USB wireless chip=
sets.
> > > > When compiled as a module, this driver will be called "rt73usb.=
ko".
> > >
> > > *sigh* you seem to be absolutely sure you want to break any form =
of
> > > consistency in the rt2x00 KConfig entry. So to show how I would l=
ike to
> > > see it I have the following patch. Unless you have objections aga=
inst
> > > below changes I will push this forward.
> >
> > No objection, but note that:
> > * this has both "hardware that feature*s*" and  "hardware that feat=
ure"
>
> I'll fix that.
>
> > * The names of drivers are duplicated and not exactly the same. For
> > example, "This is the experimental rt2500pci driver [...]" vs "[...=
] this
> > driver will be called "rt2500pci.ko"".
>
> I'll change that to:
> This is the experimental rt2500pci driver [...]" vs "[...] the module=
 will
> be called "rt2500pci.ko"".
>
> > Here is the third version of my patch.
>
> NACK
>
> All my complaints about your previous patch still aplies to this new =
one,
> and I am not going to repeat myself over and over again for exactly t=
he
> same.
Certainly not; my last update was specifically to address some of your=20
complaints. Which one(s) did I forget to address?
>
> As for the bug this patch is supposedly going to fix,
> the config option is named:
> 	tristate "Ralink rt2500 usb support"
> How can people confuse that with pci support?
> =DDour patch suggests the confusion is to blame because there is a sp=
ace
> between rt2500 and usb, and that usb isn't capitalized...
It's the text quoted in the bug report which *might* be confusing. Lack=
 of=20
capitalization isn't going to confuse anyone, of course.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html