From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
rt2400-devel@lists.sourceforge.net
Subject: Re: [PATCH 4/9] rt2x00: Use rt2x00 queue numbering
Date: Mon, 21 Apr 2008 23:40:44 +0200 [thread overview]
Message-ID: <200804212340.45024.IvDoorn@gmail.com> (raw)
In-Reply-To: <1208800577.26186.125.camel@johannes.berg>
On Monday 21 April 2008, Johannes Berg wrote:
>
> > > This function only exists to move the translation in a single location.
> > > When the translation isn't needed anymore because skb_get_queue_mapping(skb)
> > > or something else is used, then this function can be removed completely. :)
> >
> > Ps. Can I assume that skb_get_queue_mapping(skb) or whatever replacement
> > for control->queue will make sure the given queue will not exceed the max
> > number of supported queues as configured by the driver (through hw->queues)?
> >
> > Or should the driver drop such packets or resolve it to the highest queue available?
>
> Well there are two cases.
>
> (1) MQ is not configured -> it always returns 0
> (2) MQ is configured, mac80211 will create a device with hw->queues
> queues, so it'll be in the range [0 .. hw->queues-1]
Excellent.
That means the same assumptions can be made about the queue parameter
as with the old solution. :)
Ivo
next prev parent reply other threads:[~2008-04-21 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804211858.46659.IvDoorn@gmail.com>
2008-04-21 16:59 ` [PATCH 1/9] rt2x00: Support hardware RTS and CTS-to-self frames Ivo van Doorn
2008-04-21 16:59 ` [PATCH 2/9] rt2x00: Remove DRIVER_SUPPORT_MIXED_INTERFACES Ivo van Doorn
2008-04-21 17:00 ` [PATCH 3/9] rt2x00: Don't enable short preamble for 1MBs Ivo van Doorn
2008-04-21 17:00 ` [PATCH 4/9] rt2x00: Use rt2x00 queue numbering Ivo van Doorn
2008-04-21 17:17 ` Johannes Berg
2008-04-21 17:30 ` Ivo van Doorn
2008-04-21 17:58 ` Ivo van Doorn
2008-04-21 17:56 ` Johannes Berg
2008-04-21 21:40 ` Ivo van Doorn [this message]
2008-04-21 17:01 ` [PATCH 5/9] rt2x00: Fix quality/activity led handling Ivo van Doorn
2008-04-21 17:01 ` [PATCH 6/9] rt2x00: Clarify supported chipsets in Kconfig Ivo van Doorn
2008-04-21 17:01 ` [PATCH 7/9] rt2x00: Add helper macros Ivo van Doorn
2008-04-21 17:02 ` [PATCH 8/9] rt2x00: Fix kernel-doc Ivo van Doorn
2008-04-21 17:02 ` [PATCH 9/9] rt2x00: Release rt2x00 2.1.5 Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804212340.45024.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).