* [PATCH stable 1/4] ssb: Fix all-ones boardflags
@ 2008-04-24 18:00 Michael Buesch
0 siblings, 0 replies; only message in thread
From: Michael Buesch @ 2008-04-24 18:00 UTC (permalink / raw)
To: stable; +Cc: bcm43xx-dev, linux-wireless
From: Larry Finger <Larry.Finger@lwfinger.net>
In the SSB SPROM a field set to all ones means the value
is not defined in the SPROM.
In case of the boardflags, we need to set them to zero
to avoid confusing drivers. Drivers will only check the
flags by ANDing.
This patch is in wireless-testing.git, commit
d30cdf8a251e88e58bc566f5acaa9eb97ac102e9
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Gabor Stefanik <netrolller.3d@gmail.com>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: linux-2.6.25/drivers/ssb/pci.c
===================================================================
--- linux-2.6.25.orig/drivers/ssb/pci.c 2008-04-17 17:11:28.000000000 +0200
+++ linux-2.6.25/drivers/ssb/pci.c 2008-04-19 17:56:54.000000000 +0200
@@ -482,6 +482,11 @@ static int sprom_extract(struct ssb_bus
goto unsupported;
}
+ if (out->boardflags_lo == 0xFFFF)
+ out->boardflags_lo = 0; /* per specs */
+ if (out->boardflags_hi == 0xFFFF)
+ out->boardflags_hi = 0; /* per specs */
+
return 0;
unsupported:
ssb_printk(KERN_WARNING PFX "Unsupported SPROM revision %d "
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-04-24 18:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-24 18:00 [PATCH stable 1/4] ssb: Fix all-ones boardflags Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).