Re: mac80211 truesize bugs

Johannes Berg
2008-05-03T23:15:56Z

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

On Sat, 2008-05-03 at 16:07 -0700, David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Sun, 04 May 2008 00:56:23 +0200
>
> > This was a stupid mistake, if you do it correctly it actually works and
> > so far has only triggered a single warning on my system:
> >
> > [ 217.507048] SKB BUG: Invalid truesize (4294964120) size=432, sizeof(sk_buff)=176
> > ﻿
> > that was with my patch though to update skb->truesize during !skb->sk
> > pskb_expand_head() calls.
>
> Thanks a lot for tracking this down Johannes.

No, no, I haven't. The only thing that was a stupid mistake was my
change to check the actual allocated skb size in the truesize bug rather
than do the < len check... That works, when you do it as in that patch,
but the mac80211 stuff still stands (along with all the questions I
posted elsewhere in this thread)