From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: mb@bu3sch.de, netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: mac80211 truesize bugs
Date: Thu, 01 May 2008 02:56:35 -0700 (PDT) [thread overview]
Message-ID: <20080501.025635.216053297.davem@davemloft.net> (raw)
In-Reply-To: <1209635299.4008.21.camel@johannes.berg>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Thu, 01 May 2008 11:48:19 +0200
> > Signed-off-by: David S. Miller <davem@davemloft.net>
>
> > + /* This is safe because the buffer has been orphaned. */
> > + skb->truesize += sizeof(*rthdr);
>
> Hmm. The disconnect between truesize and skb->len+sizeof(*skb) was
> usually 17 or 19 bytes and sizeof(*rthdr) is only 11. On the other hand,
> I don't see where the other bytes should be coming from. I'll give this
> a try, thanks.
Grrr, I bet it's coming from a combination of the
skb_set_mac_header(skb, 0); call done by mac80211 and the skb_push()
calls in net/packet/af_packet.c
davem@sunset:~/src/GIT/net-2.6$ egrep skb_push net/packet/af_packet.c
skb_push(skb, skb->data - skb_mac_header(skb));
skb_push(skb, skb->data - skb_mac_header(skb));
skb_push(skb, skb->data - skb_mac_header(skb));
davem@sunset:~/src/GIT/net-2.6$
next prev parent reply other threads:[~2008-05-01 9:56 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 2:02 mac80211 truesize bugs Johannes Berg
2008-05-01 8:58 ` Michael Buesch
2008-05-01 9:08 ` Johannes Berg
2008-05-01 9:20 ` David Miller
2008-05-01 9:32 ` Johannes Berg
2008-05-01 9:43 ` David Miller
2008-05-01 9:48 ` Johannes Berg
2008-05-01 9:56 ` David Miller [this message]
2008-05-01 10:08 ` Johannes Berg
2008-05-01 10:32 ` David Miller
2008-05-01 10:45 ` Johannes Berg
2008-05-01 10:36 ` Herbert Xu
2008-05-01 10:49 ` David Miller
2008-05-01 10:53 ` David Miller
2008-05-01 10:58 ` Johannes Berg
2008-05-01 11:03 ` Herbert Xu
2008-05-02 20:38 ` Johannes Berg
2008-05-02 23:33 ` David Miller
2008-05-03 9:37 ` Johannes Berg
2008-05-03 14:25 ` Johannes Berg
2008-05-13 3:17 ` David Miller
2008-05-13 20:39 ` John W. Linville
2008-05-13 20:59 ` Johannes Berg
2008-05-13 21:12 ` Tomas Winkler
2008-05-13 21:37 ` Johannes Berg
2008-05-13 22:09 ` David Miller
2008-05-03 11:52 ` Johannes Berg
2008-05-04 1:03 ` David Miller
2008-05-04 1:42 ` Johannes Berg
2008-05-04 2:02 ` Herbert Xu
2008-05-04 2:08 ` Johannes Berg
2008-05-04 2:12 ` Herbert Xu
2008-05-04 2:22 ` Johannes Berg
2008-05-04 3:16 ` Herbert Xu
2008-05-04 8:47 ` Johannes Berg
2008-05-04 9:14 ` Johannes Berg
2008-05-04 9:44 ` Herbert Xu
2008-05-04 9:52 ` Johannes Berg
2008-05-04 11:25 ` Johannes Berg
2008-05-04 12:28 ` Johannes Berg
2008-05-04 12:45 ` Herbert Xu
2008-05-04 12:48 ` Johannes Berg
2008-05-04 12:52 ` Johannes Berg
2008-05-04 12:56 ` Herbert Xu
2008-05-04 13:00 ` Johannes Berg
2008-05-04 14:06 ` Johannes Berg
2008-05-04 16:03 ` Johannes Berg
2008-05-04 17:47 ` Johannes Berg
2008-05-04 22:45 ` David Miller
2008-05-04 22:48 ` Johannes Berg
2008-05-04 22:38 ` David Miller
2008-05-04 2:09 ` Johannes Berg
2008-05-03 12:38 ` Johannes Berg
2008-05-03 12:59 ` Herbert Xu
2008-05-03 16:03 ` Johannes Berg
2008-05-03 22:56 ` Johannes Berg
2008-05-03 23:07 ` David Miller
2008-05-03 23:15 ` Johannes Berg
2008-05-01 11:02 ` Herbert Xu
2008-05-01 11:38 ` Johannes Berg
2008-05-03 23:24 ` Johannes Berg
2008-05-03 23:32 ` David Miller
2008-05-03 23:43 ` Johannes Berg
2008-05-01 11:49 ` Johannes Berg
2008-05-01 12:05 ` Johannes Berg
2008-05-01 9:32 ` Michael Buesch
2008-05-01 9:34 ` Johannes Berg
2008-05-04 1:55 ` frame status API? (was: mac80211 truesize bugs) Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501.025635.216053297.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox