From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Subject: Re: rt61pci/rt73usb: Hardware decryption IV/EIV
Date: Fri, 2 May 2008 22:59:19 +0200 [thread overview]
Message-ID: <200805022259.20118.IvDoorn@gmail.com> (raw)
In-Reply-To: <1209760939.3608.20.camel@johannes.berg>
On Friday 02 May 2008, Johannes Berg wrote:
>
> > Now there you mention something. Looking at the Legacy driver, they only mention
> > ICV during the TX, but never during RX. I did find that the MMIC is appended at the
> > end of the frame, which is good, but they never do anything that looks like the
> > stripping of the ICV data...
> > So I assume it is stripped in the hardware, but no descriptor definition indicates
> > a ICV field like there is for IV and EIV. Unless.... they do have a 32bits "reserved" field
> > located directly after the IV/EIV fields.. makes one curious if that accidently contains ICV data. ;)
>
> Heh. Maybe the hardware actually does replay protection so it doesn't
> matter?
The comments in the legacy driver indicates the IV/EIV data was provided for replay attack checking,
and I do see a lot of ReplayCounters being memcpy'ed and memcmp() in the driver.
What is missing is the intialization of those counters to anything other then 0, and
the actual usage of the IV/EIV data in the Rx descriptor. ;)
Ivo
next prev parent reply other threads:[~2008-05-02 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 19:41 rt61pci/rt73usb: Hardware decryption IV/EIV Ivo van Doorn
2008-05-02 20:11 ` Johannes Berg
2008-05-02 20:38 ` Ivo van Doorn
2008-05-02 20:42 ` Johannes Berg
2008-05-02 20:59 ` Ivo van Doorn [this message]
2008-05-02 21:02 ` Johannes Berg
2008-05-02 21:28 ` Ivo van Doorn
2008-05-02 21:53 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805022259.20118.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).