public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: tomasw@gmail.com, linville@tuxdriver.com, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [RFC v2] mac80211: assign needed_headroom/tailroom for netdevs
Date: Mon, 05 May 2008 17:08:05 -0700 (PDT)	[thread overview]
Message-ID: <20080505.170805.127854312.davem@davemloft.net> (raw)
In-Reply-To: <1210032076.8012.49.camel@johannes.berg>

From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 06 May 2008 02:01:16 +0200

> Right. I just checked, and realised I remembered wrongly, wpa_supplicant
> actually binds the socket to the ethertype it wants so
> dev_queue_xmit_nit() shouldn't be called. I'll have to check why I got
> so many cloned packets, best see if it still happens with the
> header_cloned() change.

skb_cloned() is fine, that's what every TCP packet is.

skb_header_cloned() is what we expect to be false

I look forward to the results of your investigation :-)

  reply	other threads:[~2008-05-06  0:08 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04 21:24 [RFC] mac80211: assign needed_headroom/tailroom for netdevs Johannes Berg
2008-05-04 21:31 ` Johannes Berg
2008-05-04 21:32 ` [RFC v2] " Johannes Berg
2008-05-05  0:30   ` David Miller
2008-05-05  7:22     ` Johannes Berg
2008-05-05 14:27       ` Tomas Winkler
2008-05-05 15:22         ` Johannes Berg
2008-05-05 17:15           ` Tomas Winkler
2008-05-05 17:57             ` Johannes Berg
2008-05-05 18:58               ` David Miller
2008-05-05 19:05                 ` Johannes Berg
2008-05-05 19:50                   ` David Miller
2008-05-05 19:57                     ` Johannes Berg
2008-05-05 20:02                       ` David Miller
2008-05-05 20:10                         ` Johannes Berg
2008-05-05 20:44                           ` David Miller
2008-05-05 20:57                             ` Johannes Berg
2008-05-05 21:01                               ` David Miller
2008-05-05 22:37                               ` David Miller
2008-05-05 22:44                                 ` Johannes Berg
2008-05-05 23:14                                   ` David Miller
2008-05-05 23:23                                     ` Johannes Berg
2008-05-05 23:39                                       ` David Miller
2008-05-06  0:01                                         ` Johannes Berg
2008-05-06  0:08                                           ` David Miller [this message]
2008-05-06 11:13                                             ` Johannes Berg
2008-05-06  1:32                                         ` Herbert Xu
2008-05-13  5:01                                 ` David Miller
2008-05-05 23:03           ` David Miller
2008-05-05 23:17             ` Johannes Berg
2008-05-05 23:24               ` David Miller
2008-05-05 23:30                 ` Johannes Berg
2008-05-05 23:36             ` Johannes Berg
2008-05-05 23:40               ` David Miller
2008-05-13  3:52   ` David Miller
2008-05-13  9:01     ` Johannes Berg
2008-05-13  9:45       ` David Miller
2008-05-13 10:07         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080505.170805.127854312.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox