From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: Don't encrypt beacons
Date: Mon, 5 May 2008 20:36:07 +0200 [thread overview]
Message-ID: <200805052036.07862.IvDoorn@gmail.com> (raw)
In-Reply-To: <1210005414.8245.40.camel@johannes.berg>
On Monday 05 May 2008, Johannes Berg wrote:
> Hi,
>
> > This patch is intended to for your experimental patch:
> > 019-mac80211-tx-info-skb-cb.patch
> >
> > Beacons shouldn't be encryped, so mac80211 should set
> > the IEEE80211_TX_CTL_DO_NOT_ENCRYPT flag in tx info flags.
> > Otherwise the driver will cause a NULL pointer dereference
> > when it tries to access the info->control.hw_key which isn't
> > configured.
>
> Shouldn't this apply before that change as well? I'll happily roll it
> into the skb->cb/txinfo patch, but it seems it should be there w/o that
> too.
Hmm, your absolutely right, I hadn't checked the wireless-testing code yet. :)
I only noticed this bug since a user had hostapd running on rt2x00.git with
rt61pci HW crypto enabled.
I'll respin the patch to apply for wireless-testing ;)
Ivo
next prev parent reply other threads:[~2008-05-05 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 16:41 [RFC] mac80211: Don't encrypt beacons Ivo van Doorn
2008-05-05 16:36 ` Johannes Berg
2008-05-05 18:36 ` Ivo van Doorn [this message]
2008-05-05 18:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805052036.07862.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox