Re: [PATCH] mac80211: Add RTNL version of ieee80211_iterate_active_interfaces

[Ivo van Doorn <ivdoorn@gmail.com>]

On Tuesday 06 May 2008, Johannes Berg wrote:
> 
> > +	 * requested configurations, make sure to use
> > +	 * the _rtnl version since the regular version
> > +	 * requires atomic context.
> 
> That's a bit misleading, the regular version requires that the callback
> is atomic :)

Ok, will fix.

> > +	 */
> > +	rtnl_lock();
> > +	ieee80211_iterate_active_interfaces_rtnl(rt2x00dev->hw,
> > +						 rt2x00lib_intf_scheduled_iter,
> > +						 rt2x00dev);
> > +	rtnl_unlock();
> 
> >  /**
> > + * ieee80211_iterate_active_interfaces_rtnl - iterate active interfaces
> > + *
> > + * This function iterates over the interfaces associated with a given
> > + * hardware that are currently active and calls the callback for them.
> > + * This function allows the iterator function to sleep, the caller is
> > + * responsible for proper locking mechanisms to prevent concurrency.
> 
> That description seems misleading. Also, since the mac80211 internal
> list management could possibly change (I don't see it changing but who
> knows), I think I'd prefer if this function acquired the rtnl itself

Ok, that is what I prefered as well, but the patch reverted it to the
original version ;)

> didn't have rtnl in the name. Can't think of a good name right now,
> maybe rename the other one to _atomic?

Ok, will fix.

Ivo