Re: [PATCH] mac80211: rewrite fragmentation code

[Michael Buesch <mb@bu3sch.de>]

On Thursday 08 May 2008 15:08:46 Herbert Xu wrote:
> On Thu, May 08, 2008 at 03:00:00PM +0200, Michael Buesch wrote:
> >
> > Ok, what about DMA error. kmalloc error or something else?
> > ring overflow was a bad example, of course.
> 
> If your NIC gets DMA errors all the time then I suggest you
> invest in some new hardware.  Ditto if you fail to kmalloc all
> the time.
> 
> If they're rare as they should be then dropping the packet is
> perfectly reasonable.

Ok, why is nobody actually answering my _question_? :)
So I'll try to answer it by myself: the hard_start_xmit callback
is actually supposed to return "void", but it returns "int" just
for historical reasons. So there is no way to fail in a TX handler.
If a failure happens, the driver must free and drop the skb.
How likely errors are is a completely different story. One could argue
that errors are unlikely for any part of the kernel, except for very
sone special cases.

So does that also apply to the wireless stack? Should we change drivers
to always return 0. later we can change the function prototype to return void.

-- 
Greetings Michael.