linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Subject: [PATCH 2/5] mac80211: Initialize sta pointer
Date: Sat, 10 May 2008 13:50:43 +0200	[thread overview]
Message-ID: <200805101350.43435.IvDoorn@gmail.com> (raw)
In-Reply-To: <200805101349.19481.IvDoorn@gmail.com>

patch: mac80211: rewrite fragmentation code
introduced the following compile warning:

net/mac80211/tx.c: In function 'ieee80211_master_start_xmit':
net/mac80211/tx.c:1244: warning: 'sta' may be used uninitialized in this function

sta is allowed to be NULL throughout the rest of the function,
so we best initialize it to NULL.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
 net/mac80211/tx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 2ac891f..2aaf866 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1241,7 +1241,7 @@ static bool validate_control(struct ieee80211_local *local,
 	struct ieee80211_sub_if_data *sdata;
 	struct ieee80211_key *key;
 	struct ieee80211_hdr *hdr = (void *)skb->data;
-	struct sta_info *sta;
+	struct sta_info *sta = NULL;
 	u8 *da;
 
 	list_for_each_entry_rcu(sdata, &local->interfaces, list) {
-- 
1.5.5.1


  parent reply	other threads:[~2008-05-10 12:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-10 11:49 [PATCH 0/5] mac80211 & rt2x00 updates Ivo van Doorn
2008-05-10 11:49 ` [PATCH 1/5] rt2x00: use rate index in TX control Ivo van Doorn
2008-05-10 11:50 ` [PATCH 3/5] rt2x00: use multi-queue master netdevice Ivo van Doorn
2008-05-10 11:50 ` Ivo van Doorn [this message]
2008-05-10 16:22   ` [PATCH 2/5] mac80211: Initialize sta pointer Johannes Berg
2008-05-10 11:51 ` [PATCH 4/5] rt2x00: Convert rt2x00 to read control info from skb->cb Ivo van Doorn
2008-05-10 21:20   ` Johannes Berg
2008-05-11  9:13     ` Ivo van Doorn
2008-05-11 11:33       ` Ivo van Doorn
2008-05-11 11:49         ` Johannes Berg
2008-05-11 12:13           ` Ivo van Doorn
2008-05-10 11:51 ` [PATCH 5/5] mac80211: Match define names in comments with actual defines Ivo van Doorn
2008-05-10 16:21   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805101350.43435.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rt2400-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).