From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFT/C 2/7] mac80211: clean up skb reallocation code
Date: Mon, 12 May 2008 02:09:04 -0700 (PDT) [thread overview]
Message-ID: <20080512.020904.187999229.davem@davemloft.net> (raw)
In-Reply-To: <20080510221906.261962000@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Sun, 11 May 2008 00:18:47 +0200
In patch one, you changed the call site of this new
ieee80211_skb_resize() to properly use skb_header_cloned(). But
skb_cloned snuck back into the statistics code in this patch:
> + if (skb_cloned(skb))
> + I802_DEBUG_INC(local->tx_expand_skb_head_cloned);
> + else
> + I802_DEBUG_INC(local->tx_expand_skb_head);
next prev parent reply other threads:[~2008-05-12 9:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 22:18 [RFT/C 0/7] various mac80211 updates/bugfixes Johannes Berg
2008-05-10 22:18 ` [RFT/C 1/7] mac80211: use skb_header_cloned() Johannes Berg
2008-05-12 9:09 ` David Miller
2008-05-10 22:18 ` [RFT/C 2/7] mac80211: clean up skb reallocation code Johannes Berg
2008-05-12 9:09 ` David Miller [this message]
2008-05-13 8:39 ` Johannes Berg
2008-05-13 8:39 ` David Miller
2008-05-10 22:18 ` [RFT/C 3/7] mac80211: fix bugs in queue handling functions Johannes Berg
2008-05-10 22:18 ` [RFT/C 4/7] mac80211: let drivers wake but not start queues Johannes Berg
2008-05-12 9:10 ` David Miller
2008-05-10 22:18 ` [RFT/C 5/7] mac80211: use rate index in TX control Johannes Berg
2008-05-10 22:18 ` [RFT/C 6/7] mac80211: reorder some transmit handlers Johannes Berg
2008-05-10 22:18 ` [RFT/C 7/7] mac80211: move TX info into skb->cb Johannes Berg
2008-05-12 9:11 ` David Miller
2008-05-12 12:26 ` Ivo van Doorn
2008-05-13 8:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512.020904.187999229.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).