Re: [PATCH] [NET] libertas: check for mesh support before trying to use it

["John W. Linville" <linville@tuxdriver.com>]

On Mon, May 12, 2008 at 10:51:36PM +0200, Sebastian Siewior wrote:
> * Dan Williams | 2008-05-12 12:34:16 [-0400]:
> 
> >> diff --git a/drivers/net/wireless/libertas/ethtool.c b/drivers/net/wireless/libertas/ethtool.c
> >> index dcfdb40..a79d698 100644
> >> --- a/drivers/net/wireless/libertas/ethtool.c
> >> +++ b/drivers/net/wireless/libertas/ethtool.c
> >> @@ -113,8 +113,14 @@ static void lbs_ethtool_get_stats(struct net_device * dev,
> >>  
> >>  static int lbs_ethtool_get_sset_count(struct net_device * dev, int sset)
> >>  {
> >> +	struct lbs_private *priv = dev->priv;
> >> +
> >>  	switch (sset) {
> >>  	case ETH_SS_STATS:
> >> +
> >> +		if (!priv->mesh_tlv)
> >> +
> >
> >We usually use
> >
> >if (!priv->mesh_dev)
> >
> >for checking whether mesh is open or not... Will that not work here?
> >
> Well, if this is the case than you can pick David's patch which does
> this [1]. If you fine with this than I could add a patch description and
> things like that :)
> 
> [1] http://article.gmane.org/gmane.linux.kernel.wireless.general/13707

These competing patches have been under discussion for a month.
Can we get some consensus on which patch or patches we want?

John
-- 
John W. Linville
linville@tuxdriver.com