From: "John W. Linville" <linville@tuxdriver.com>
To: Pavel Roskin <proski@gnu.org>
Cc: Mathieu Chouquet-Stringer <mchouque@free.fr>,
j@w1.fi, linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] hostap: procfs fix for hostap_fw.c
Date: Mon, 12 May 2008 20:43:45 -0400 [thread overview]
Message-ID: <20080513004345.GB26418@tuxdriver.com> (raw)
In-Reply-To: <1210592626.3372.6.camel@dv>
On Mon, May 12, 2008 at 07:43:46AM -0400, Pavel Roskin wrote:
> On Tue, 2008-05-06 at 17:23 +0200, Mathieu Chouquet-Stringer wrote:
>
> > Problem is local->proc has now been overwritten by hostap_init_proc
> > meaning "registers" isn't removed. When you reload the module you get
> > an error telling you "registers" already exists (and you then get
> > duplicate "registers" files in /proc).
>
> I've seen it many times. Thanks for tracking it down! I've tested the
> patch with PCI and PCMCIA devices, and everything appears to be
> correct. /proc/registers is not created, "registers" is created
> under /proc/net/hostap/wlan0/, no more warnings.
>
> > Signed-off-by: Mathieu Chouquet-Stringer <mchouque@free.fr>
>
> Acked-off-by: Pavel Roskin <proski@gnu.org>
>
> If a more concise description needs to be written, I can do it.
If you don't mind, I would appreciate a more concise description.
I appreciate the full description of the bug, but I think it is a
bit much for the changelog as-is.
Thanks!
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-05-13 0:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 15:23 [PATCH] hostap: procfs fix for hostap_fw.c Mathieu Chouquet-Stringer
2008-05-12 11:43 ` Pavel Roskin
2008-05-13 0:43 ` John W. Linville [this message]
2008-05-16 8:40 ` Mathieu Chouquet-Stringer
-- strict thread matches above, loose matches on Subject: below --
2008-05-16 13:26 Mathieu Chouquet-Stringer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513004345.GB26418@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=mchouque@free.fr \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).