From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 5/5] mac80211: move TX info into skb->cb
Date: Thu, 15 May 2008 13:32:34 +0200 [thread overview]
Message-ID: <200805151332.35758.IvDoorn@gmail.com> (raw)
In-Reply-To: <1210849867.8709.0.camel@johannes.berg>
On Thursday 15 May 2008, Johannes Berg wrote:
> On Thu, 2008-05-15 at 12:55 +0200, Johannes Berg wrote:
> > plain text document attachment (019-mac80211-tx-info-skb-cb.patch)
> > This patch converts mac80211 and all drivers to have transmit
> > information and status in skb->cb rather than allocating extra
> > memory for it and copying all the data around. To make it fit,
> > a union is used where only data that is necessary for all steps
> > is kept outside of the union.
> >
> > A number of fixes were done by Ivo, as well as the rt2x00 part
> > of this patch.
>
> I mangled it a bit though so you may want to check it, mac80211 now sets
> REQ_TX_STATUS so you can use that for status reporting, but you can't
> use it for queue kicking at least not in the future when mac80211 might
> not set it on all frames.
Well queue kicking from driver to mac80211 is in rt2x00 based on txdone
events on a particular queue. (When frame was succesfully transmitted
and is no longer full, then the queue will be awakened by rt2x00).
I am changing this a bit to support burst events that will send all
fragments in a single run, but that is currently under testing in rt2x00.git.
Ivo
next prev parent reply other threads:[~2008-05-15 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 10:55 [PATCH 0/5] mac80211 fixes & improvements Johannes Berg
2008-05-15 10:55 ` [PATCH 1/5] mac80211: fix bugs in queue handling functions Johannes Berg
2008-05-15 10:55 ` [PATCH 2/5] mac80211: let drivers wake but not start queues Johannes Berg
2008-05-15 10:55 ` [PATCH 3/5] mac80211: use rate index in TX control Johannes Berg
2008-05-15 10:55 ` [PATCH 4/5] mac80211: reorder some transmit handlers Johannes Berg
2008-05-15 10:55 ` [PATCH 5/5] mac80211: move TX info into skb->cb Johannes Berg
2008-05-15 11:11 ` Johannes Berg
2008-05-15 11:32 ` Ivo van Doorn [this message]
2008-05-15 11:22 ` Johannes Berg
2008-05-15 11:58 ` Ivo van Doorn
2008-05-15 11:49 ` Johannes Berg
2008-05-22 3:10 ` John W. Linville
2008-05-22 7:25 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805151332.35758.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).