From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: libertas-dev@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] libertas: fix multicast filtering on eth and msh interfaces.
Date: Tue, 20 May 2008 09:51:14 +0200 [thread overview]
Message-ID: <200805200951.14516.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <1211208955.21380.163.camel@pmac.infradead.org>
This patch introduces trailing blanks, e.g. here:
> + dev = (dev==priv->mesh_dev?NULL:priv->mesh_dev)) {
> + if ((dev_get_flags(dev) & (IFF_UP|IFF_MULTICAST)) !=
> + (IFF_UP|IFF_MULTICAST))
> + continue;
The whole warning was: Warning: trailing whitespace in lines
621,625,654 of drivers/net/wireless/libertas/main.c.
I also had one patch reject against wireless-testing,
v2.6.26-rc2-7503-gc24e096, which was easy to fix:
@@ -1169,6 +1202,7 @@ int lbs_remove_card(struct lbs_private *priv)
cancel_delayed_work(&priv->scan_work);
cancel_delayed_work(&priv->assoc_work);
+ cancel_work_sync(&priv->mcast_work);
destroy_workqueue(priv->work_thread);
if (priv->psmode == LBS802_11POWERMODEMAX_PSP) {
next prev parent reply other threads:[~2008-05-20 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 14:55 [PATCH] libertas: fix multicast filtering on eth and msh interfaces David Woodhouse
2008-05-19 15:53 ` Dan Williams
2008-05-20 7:51 ` Holger Schurig [this message]
2008-05-20 13:19 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805200951.14516.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=dwmw2@infradead.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).