BUG: scheduling while atomic (2.6.26-rc3...)

BUG: scheduling while atomic (2.6.26-rc3...)

[Andrew Price]

Hi,

I'm seeing this bug when I boot but unfortunately the messages don't
seem to get logged and the system locks so I took a photo of as much as
could fit on my laptop's screen:
http://sucs.org/~welshbyte/wirelesstraces.jpg (sorry about the bad quality).

Anyway, I've bisected it down to commit
2f561feb386d6adefbad63c59a1fcd298ac6a79c "mac80211: Add RTNL version of
ieee80211_iterate_active_interfaces"

lspci says I'm using a:

02:00.0 Network controller: RaLink RT2500 802.11g Cardbus/mini-PCI (rev 01)
	Subsystem: Belkin Device 701a
	Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
	Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=slow >TAbort- <TAbort-
<MAbort- >SERR- <PERR- INTx-
	Latency: 64, Cache Line Size: 64 bytes
	Interrupt: pin A routed to IRQ 17
	Region 0: Memory at 54000000 (32-bit, non-prefetchable) [size=8K]
	Capabilities: [40] Power Management version 2
		Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-
	Kernel driver in use: rt2500pci

Let me know if you require any more information (or a clearer
photo/transcription).

--
Andy Price

Re: BUG: scheduling while atomic (2.6.26-rc3...)

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

On Fri, 2008-05-23 at 03:05 +0100, Andrew Price wrote:
> Hi,
> 
> I'm seeing this bug when I boot but unfortunately the messages don't
> seem to get logged and the system locks so I took a photo of as much as
> could fit on my laptop's screen:
> http://sucs.org/~welshbyte/wirelesstraces.jpg (sorry about the bad quality).
> 
> Anyway, I've bisected it down to commit
> 2f561feb386d6adefbad63c59a1fcd298ac6a79c "mac80211: Add RTNL version of
> ieee80211_iterate_active_interfaces"
> 
> lspci says I'm using a:
> 
> 02:00.0 Network controller: RaLink RT2500 802.11g Cardbus/mini-PCI (rev 01)

Looks like rt2x00 actually needs both versions of the function.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: BUG: scheduling while atomic (2.6.26-rc3...)

[Ivo van Doorn]

On Friday 23 May 2008, Johannes Berg wrote:
> On Fri, 2008-05-23 at 03:05 +0100, Andrew Price wrote:
> > Hi,
> > 
> > I'm seeing this bug when I boot but unfortunately the messages don't
> > seem to get logged and the system locks so I took a photo of as much as
> > could fit on my laptop's screen:
> > http://sucs.org/~welshbyte/wirelesstraces.jpg (sorry about the bad quality).
> > 
> > Anyway, I've bisected it down to commit
> > 2f561feb386d6adefbad63c59a1fcd298ac6a79c "mac80211: Add RTNL version of
> > ieee80211_iterate_active_interfaces"
> > 
> > lspci says I'm using a:
> > 
> > 02:00.0 Network controller: RaLink RT2500 802.11g Cardbus/mini-PCI (rev 01)
> 
> Looks like rt2x00 actually needs both versions of the function.

Johannes: Thanks for the tip, I seriously overlooked that the rtnl version
grabs a mutex in interrupt context. :)

Andew: Could you try below patch to see if that works?

---
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 5645140..669d942 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -481,9 +481,9 @@ void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev)
 	if (!test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
 		return;
 
-	ieee80211_iterate_active_interfaces(rt2x00dev->hw,
-					    rt2x00lib_beacondone_iter,
-					    rt2x00dev);
+	ieee80211_iterate_active_interfaces_atomic(rt2x00dev->hw,
+						   rt2x00lib_beacondone_iter,
+						   rt2x00dev);
 
 	queue_work(rt2x00dev->hw->workqueue, &rt2x00dev->intf_work);
 }

Re: BUG: scheduling while atomic (2.6.26-rc3...)

[Andrew Price]

Hi Ivo,

On 23/05/08 15:28, Ivo van Doorn wrote:
> Andew: Could you try below patch to see if that works?

It looks good. wlan0 came up fine and dmesg looks clean, I can ping and
read email...

Seems that some traffic (ssh, http, ...) is having problems though so
I'm back on -rc1 to email you but I expect that's a different problem
altogether and I'll see if I can track it down.

> ---
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 5645140..669d942 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -481,9 +481,9 @@ void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev)
>  	if (!test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
>  		return;
>  
> -	ieee80211_iterate_active_interfaces(rt2x00dev->hw,
> -					    rt2x00lib_beacondone_iter,
> -					    rt2x00dev);
> +	ieee80211_iterate_active_interfaces_atomic(rt2x00dev->hw,
> +						   rt2x00lib_beacondone_iter,
> +						   rt2x00dev);
>  
>  	queue_work(rt2x00dev->hw->workqueue, &rt2x00dev->intf_work);
>  }
> 

Thanks,

--
Andy Price

Re: BUG: scheduling while atomic (2.6.26-rc3...)

[Ivo van Doorn]

On Friday 23 May 2008, Andrew Price wrote:
> Hi Ivo,
> 
> On 23/05/08 15:28, Ivo van Doorn wrote:
> > Andew: Could you try below patch to see if that works?
> 
> It looks good. wlan0 came up fine and dmesg looks clean, I can ping and
> read email...

Excellent, I'll push the patch upstream then. :)

Ivo

> Seems that some traffic (ssh, http, ...) is having problems though so
> I'm back on -rc1 to email you but I expect that's a different problem
> altogether and I'll see if I can track it down.
> 
> > ---
> > diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> > index 5645140..669d942 100644
> > --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> > +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> > @@ -481,9 +481,9 @@ void rt2x00lib_beacondone(struct rt2x00_dev *rt2x00dev)
> >  	if (!test_bit(DEVICE_ENABLED_RADIO, &rt2x00dev->flags))
> >  		return;
> >  
> > -	ieee80211_iterate_active_interfaces(rt2x00dev->hw,
> > -					    rt2x00lib_beacondone_iter,
> > -					    rt2x00dev);
> > +	ieee80211_iterate_active_interfaces_atomic(rt2x00dev->hw,
> > +						   rt2x00lib_beacondone_iter,
> > +						   rt2x00dev);
> >  
> >  	queue_work(rt2x00dev->hw->workqueue, &rt2x00dev->intf_work);
> >  }
> > 
> 
> Thanks,
> 
> --
> Andy Price
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>