From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: "Johan Adolfsson" <Johan.Adolfsson@axis.com>
Cc: libertas-dev@lists.infradead.org,
"'Dan Williams'" <dcbw@redhat.com>,
linux-wireless@vger.kernel.org,
"'John W. Linville'" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: before sleeping, check for a command result
Date: Fri, 23 May 2008 16:57:42 +0200 [thread overview]
Message-ID: <200805231657.42433.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <002701c8bce1$04097010$0137550a@se.axis.com>
> I have experience a couple of timeout and resends and after
> sending another commands I get the response from the previous
> one, and the patch seems to solve a couple of those for me -
> still se some problem fetching packet from firmware with ret
> = -22 though. And it could be dependant on how much debug I
> have turned on..
Keep in mind that maybe the firmware actually really takes ages
to complete a command. David Woodhouse reported this.
In my case, because I had the proper debugging statements in my
interrupt handler, I knew for sure that I already received the
response. Can you verify that, for the comment timeouts you
noticed, if this did happen or not?
> But, shouldn't the above priv->event_fifo check move before
> cur_cmd as well?
Maybe, my change to the thread was just a shot into the dark, I
don't claim that I fully understand it. Maybe Dan or David can
help you with this.
> I have no clue what kind of events we are talking about here
> and if those can be processed independent of if a cmd is
> running or not, just trigged on the comment.
The kfifo contains hostevents (e.g. link lost, deauthenticated)
and command responses. Hmm, not sure if the latter is still
true.
next prev parent reply other threads:[~2008-05-23 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 14:04 [PATCH] libertas: before sleeping, check for a command result Holger Schurig
2008-05-23 14:26 ` Johan Adolfsson
2008-05-23 14:32 ` Dan Williams
2008-05-25 20:28 ` Holger Schurig
2008-05-23 14:57 ` Holger Schurig [this message]
2008-05-26 16:14 ` Johan Adolfsson
2008-05-27 20:08 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805231657.42433.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=Johan.Adolfsson@axis.com \
--cc=dcbw@redhat.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).