From: Matthew Wilcox <matthew@wil.cx>
To: Daniel Walker <dwalker@mvista.com>
Cc: Dan Williams <dcbw@redhat.com>,
linville@tuxdriver.com, rusty@rustcorp.com.au, mingo@elte.hu,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
arjan@infradead.org
Subject: Re: [PATCH] net: wireless: airo semaphore to mutex
Date: Tue, 27 May 2008 09:34:06 -0600 [thread overview]
Message-ID: <20080527153406.GL30894@parisc-linux.org> (raw)
In-Reply-To: <1211900915.18130.251.camel@localhost.localdomain>
On Tue, May 27, 2008 at 08:08:35AM -0700, Daniel Walker wrote:
>
> On Tue, 2008-05-27 at 09:48 -0400, Dan Williams wrote:
> >
> > Yeah, that might be the right way to go. If you want to jump into the
> > driver, feel quite free, but I don't think you need to go into too much
> > detail with it. Your overall behavior analysis is right on the mark
> > already.
>
> I think we could just remove the trylock from the interrupt case, and
> always force the wake_up_interruptible(&priv->thr_wait) case. It looks
> like the trylocking is just an optimization to save a wakeup ..
'just'? I think you'd see severe performance reductions if you had to
do a wakeup for every interrupt.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-05-27 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 23:21 [PATCH] net: wireless: airo semaphore to mutex Daniel Walker
2008-05-26 17:29 ` Michal Schmidt
2008-05-26 17:59 ` Daniel Walker
2008-05-27 1:17 ` Rusty Russell
2008-05-27 2:15 ` Matthew Wilcox
2008-05-27 4:34 ` Daniel Walker
2008-05-27 11:24 ` Matthew Wilcox
2008-05-27 4:37 ` Rusty Russell
2008-05-27 13:13 ` Matthew Wilcox
2008-05-27 13:48 ` Dan Williams
2008-05-27 15:08 ` Daniel Walker
2008-05-27 15:34 ` Matthew Wilcox [this message]
2008-05-27 16:01 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080527153406.GL30894@parisc-linux.org \
--to=matthew@wil.cx \
--cc=arjan@infradead.org \
--cc=dcbw@redhat.com \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).