linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Zhu Yi <yi.zhu@intel.com>
Cc: linux-wireless@vger.kernel.org, Guy Cohen <guy.cohen@intel.com>,
	Tomas Winkler <tomas.winkler@intel.com>
Subject: Re: [PATCH 2.6.26 1/3] iwlwifi: fix in-column rate scaling
Date: Wed, 28 May 2008 16:22:01 -0400	[thread overview]
Message-ID: <20080528202201.GC25770@tuxdriver.com> (raw)
In-Reply-To: <1211858975-21424-1-git-send-email-yi.zhu@intel.com>

On Tue, May 27, 2008 at 11:29:33AM +0800, Zhu Yi wrote:
> From: Guy Cohen <guy.cohen@intel.com>
> 
> This patch fixes cases that the code raised or didn't decrease
> the rate although the success ratio was not good.
> 
> Signed-off-by: Guy Cohen <guy.cohen@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  drivers/net/wireless/iwlwifi/iwl-4965-rs.c |   45 ++++++++++++++-------------
>  1 files changed, 23 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
> index 2adc228..fa41ed1 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-4965-rs.c
> @@ -1339,7 +1339,7 @@ static int rs_move_legacy_other(struct iwl_priv *priv,
>  				lq_sta->search_better_tbl = 1;
>  				goto out;
>  			}
> -
> +			break;
>  		case IWL_LEGACY_SWITCH_SISO:
>  			IWL_DEBUG_RATE("LQ: Legacy switch to SISO\n");
>  
> @@ -1425,9 +1425,9 @@ static int rs_move_siso_to_other(struct iwl_priv *priv,
>  				lq_sta->search_better_tbl = 1;
>  				goto out;
>  			}
> -
> +			break;
>  		case IWL_SISO_SWITCH_MIMO2:
> -			IWL_DEBUG_RATE("LQ: SISO switch to MIMO\n");
> +			IWL_DEBUG_RATE("LQ: SISO switch to MIMO2\n");
>  			memcpy(search_tbl, tbl, sz);
>  			search_tbl->is_SGI = 0;
>  			search_tbl->ant_type = ANT_AB; /*FIXME:RS*/

These hunks don't apply to wireless-2.6.

-- 
John W. Linville
linville@tuxdriver.com

  parent reply	other threads:[~2008-05-28 20:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-27  3:29 [PATCH 2.6.26 1/3] iwlwifi: fix in-column rate scaling Zhu Yi
2008-05-27  3:29 ` [PATCH 2.6.26 2/3] iwlwifi: fix exit from stay_in_table state Zhu Yi
2008-05-27  3:29   ` [PATCH 2.6.26 3/3] iwlwifi: fix rate scale TLC column selection bug Zhu Yi
2008-05-28 20:22 ` John W. Linville [this message]
2008-05-29  2:02   ` [PATCH 2.6.26 1/3] iwlwifi: fix in-column rate scaling Zhu Yi
2008-05-29  7:05     ` Tomas Winkler
2008-05-30 15:04       ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080528202201.GC25770@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=guy.cohen@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).