linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: linville@tuxdriver.com
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: pull request: wireless-2.6 2008-06-03
Date: Tue, 03 Jun 2008 14:16:52 -0700 (PDT)	[thread overview]
Message-ID: <20080603.141652.245225529.davem@davemloft.net> (raw)
In-Reply-To: <20080603190943.GB28966@tuxdriver.com>

From: "John W. Linville" <linville@tuxdriver.com>
Date: Tue, 3 Jun 2008 15:09:43 -0400

> Kirill A. Shutemov (1):
>       wireless.h: improve userland include-ability

I'm not pulling this into my tree.  I've already replied
to that patch posting saying why I don't like this.

Even if I found this change as the only way to go and therefore
had to take it in, the commit log is way too terse about what
the problem is.  And it must describe the horrifics that are
now necessary to include this file in userspace after the change.

It needs to describe in detail what the conflicting types and
definitions in the kernel headers are that cause problems with
userspace, and the exact sequence of includes userland has to make in
order to get this right.

And I require such enormously scary details in order to make it clear
how bogus this change is.

There is zero point in us sanitizing kernel headers for userspace
usage if this kind of crap is still necessary.  I mean tell me, why
should we even bother in that case?  And this is why I'm not taking in
this changeset.

  reply	other threads:[~2008-06-03 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03 19:09 pull request: wireless-2.6 2008-06-03 John W. Linville
2008-06-03 21:16 ` David Miller [this message]
2008-06-04 20:54   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080603.141652.245225529.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).