Re: [PATCH] wireless.h: improve userland include-ability

[David Miller <davem@davemloft.net>]

From: David Woodhouse <dwmw2@infradead.org>
Date: Wed, 04 Jun 2008 14:52:09 +0100

> On Tue, 2008-06-03 at 12:05 -0700, David Miller wrote:
> > Yeah, go check so me magic userspace tool header to see what magic is
> > needed just to include a core networking header file correctly.
> > 
> > No, thanks.
> 
> Just to clarify: this is only a problem for userspace, and you're
> objecting to that?

Yes.

> I'm happy enough to change that, but it means seeing stuff like...
> 	#ifndef __KERNEL__
> 	#include <sys/foo.h>
> 	#endif 
> ... in kernel headers. Is that what you're intending, or am I
> misunderstanding your objection?

I think this kind of construct shouldn't be necessary in the first
place.

> I believe that the main reason for this patch was that <linux/socket.h>
> and <linux/if.h> both have problems when you include them in the same C
> file as the 'proper' glibc equivalent? Is that something we can address,
> instead of just dropping those includes?

You will need to find a way to make it work cleanly if you want
me to take the change in :-)