From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: rt2400-devel@lists.sourceforge.net,
"John W. Linville" <linville@tuxdriver.com>,
linux-next@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [PATCH] next-20080611 rt2x00: LEDS build failure
Date: Wed, 11 Jun 2008 13:32:22 -0700 [thread overview]
Message-ID: <20080611133222.77c4a3f4.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200806112159.00779.IvDoorn@gmail.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
Config symbols that select LEDS_CLASS need to depend on NEW_LEDS so that
undefined symbols are not used in the build.
The alternative is to select NEW_LEDS, which some drivers do.
This patch fixes the led_* symbols build errors.
(.text+0x174cdc): undefined reference to `input_unregister_device'
(.text+0x174d9f): undefined reference to `input_allocate_device'
(.text+0x174e2d): undefined reference to `input_register_device'
(.text+0x174e53): undefined reference to `input_free_device'
rt2x00rfkill.c:(.text+0x176dc4): undefined reference to `input_allocate_polled_device'
rt2x00rfkill.c:(.text+0x176e8b): undefined reference to `input_event'
rt2x00rfkill.c:(.text+0x176e9f): undefined reference to `input_event'
(.text+0x176eca): undefined reference to `input_unregister_polled_device'
(.text+0x176efc): undefined reference to `input_free_polled_device'
(.text+0x176f37): undefined reference to `input_free_polled_device'
(.text+0x176fd8): undefined reference to `input_register_polled_device'
(.text+0x1772c0): undefined reference to `led_classdev_resume'
(.text+0x1772d4): undefined reference to `led_classdev_resume'
(.text+0x1772e8): undefined reference to `led_classdev_resume'
(.text+0x17730a): undefined reference to `led_classdev_suspend'
(.text+0x17731e): undefined reference to `led_classdev_suspend'
(.text+0x17732f): undefined reference to `led_classdev_suspend'
rt2x00leds.c:(.text+0x177348): undefined reference to `led_classdev_unregister'
rt2x00leds.c:(.text+0x1773c0): undefined reference to `led_classdev_register'
rfkill-input.c:(.text+0x209e4c): undefined reference to `input_close_device'
rfkill-input.c:(.text+0x209e53): undefined reference to `input_unregister_handle'
rfkill-input.c:(.text+0x209ea1): undefined reference to `input_register_handle'
rfkill-input.c:(.text+0x209eae): undefined reference to `input_open_device'
rfkill-input.c:(.text+0x209ebb): undefined reference to `input_unregister_handle'
rfkill-input.c:(.init.text+0x17405): undefined reference to `input_register_handler'
rfkill-input.c:(.exit.text+0x194f): undefined reference to `input_unregister_handler'
make[1]: *** [vmlinux] Error 1
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/wireless/rt2x00/Kconfig | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- linux-next-20080611.orig/drivers/net/wireless/rt2x00/Kconfig
+++ linux-next-20080611/drivers/net/wireless/rt2x00/Kconfig
@@ -42,7 +42,7 @@ config RT2X00_LIB_RFKILL
config RT2X00_LIB_LEDS
boolean
- depends on RT2X00_LIB
+ depends on RT2X00_LIB && NEW_LEDS
config RT2400PCI
tristate "Ralink rt2400 (PCI/PCMCIA) support"
@@ -66,7 +66,7 @@ config RT2400PCI_RFKILL
config RT2400PCI_LEDS
bool "Ralink rt2400 leds support"
- depends on RT2400PCI
+ depends on RT2400PCI && NEW_LEDS
select LEDS_CLASS
select RT2X00_LIB_LEDS
---help---
@@ -94,7 +94,7 @@ config RT2500PCI_RFKILL
config RT2500PCI_LEDS
bool "Ralink rt2500 leds support"
- depends on RT2500PCI
+ depends on RT2500PCI && NEW_LEDS
select LEDS_CLASS
select RT2X00_LIB_LEDS
---help---
@@ -124,7 +124,7 @@ config RT61PCI_RFKILL
config RT61PCI_LEDS
bool "Ralink rt2501/rt61 leds support"
- depends on RT61PCI
+ depends on RT61PCI && NEW_LEDS
select LEDS_CLASS
select RT2X00_LIB_LEDS
---help---
@@ -162,7 +162,7 @@ config RT73USB
config RT73USB_LEDS
bool "Ralink rt2501/rt73 leds support"
- depends on RT73USB
+ depends on RT73USB && NEW_LEDS
select LEDS_CLASS
select RT2X00_LIB_LEDS
---help---
next prev parent reply other threads:[~2008-06-11 20:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 17:07 next-20080611 rt2x00: build failure Randy Dunlap
2008-06-11 17:48 ` [Rt2400-devel] " Ivo van Doorn
2008-06-11 17:46 ` Randy Dunlap
2008-06-11 18:21 ` Ivo van Doorn
2008-06-11 18:10 ` John W. Linville
2008-06-11 19:03 ` [Rt2400-devel] " Ivo van Doorn
2008-06-11 19:32 ` Randy Dunlap
2008-06-11 19:59 ` Ivo van Doorn
2008-06-11 19:57 ` [PATCH] " Randy Dunlap
2008-06-11 20:32 ` Randy Dunlap [this message]
2008-06-11 22:15 ` [PATCH] next-20080611 rt2x00: LEDS " Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611133222.77c4a3f4.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=ivdoorn@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).