* [PATCH] rt2x00: RT2X00_LIB_RFKILL should depend on INPUT
@ 2008-06-11 19:19 Ivo van Doorn
2008-06-11 20:01 ` Ivo van Doorn
0 siblings, 1 reply; 2+ messages in thread
From: Ivo van Doorn @ 2008-06-11 19:19 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, rt2400-devel
rt2x00 requires the input-polldev driver for reporting rfkill events,
selecting INPUT_POLLDEV is not correct since that option depends
on the INPUT config option.
Since RT2X00_LIB_RFKILL requires the input layer as well, we should
make it depend on INPUT directly.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
John, this is for 2.6.26
diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
index 0ace761..c4d1f67 100644
--- a/drivers/net/wireless/rt2x00/Kconfig
+++ b/drivers/net/wireless/rt2x00/Kconfig
@@ -36,6 +36,7 @@ config RT2X00_LIB_FIRMWARE
config RT2X00_LIB_RFKILL
boolean
depends on RT2X00_LIB
+ depends on INPUT
select RFKILL
select INPUT_POLLDEV
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rt2x00: RT2X00_LIB_RFKILL should depend on INPUT
2008-06-11 19:19 [PATCH] rt2x00: RT2X00_LIB_RFKILL should depend on INPUT Ivo van Doorn
@ 2008-06-11 20:01 ` Ivo van Doorn
0 siblings, 0 replies; 2+ messages in thread
From: Ivo van Doorn @ 2008-06-11 20:01 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, rt2400-devel, Randy Dunlap
On Wednesday 11 June 2008, Ivo van Doorn wrote:
> rt2x00 requires the input-polldev driver for reporting rfkill events,
> selecting INPUT_POLLDEV is not correct since that option depends
> on the INPUT config option.
> Since RT2X00_LIB_RFKILL requires the input layer as well, we should
> make it depend on INPUT directly.
>
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
John, you can drop this patch in exchange for the patch just send by Randy,
since that patch would be more correct.
Thanks,
Ivo
> ---
> John, this is for 2.6.26
>
> diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
> index 0ace761..c4d1f67 100644
> --- a/drivers/net/wireless/rt2x00/Kconfig
> +++ b/drivers/net/wireless/rt2x00/Kconfig
> @@ -36,6 +36,7 @@ config RT2X00_LIB_FIRMWARE
> config RT2X00_LIB_RFKILL
> boolean
> depends on RT2X00_LIB
> + depends on INPUT
> select RFKILL
> select INPUT_POLLDEV
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-11 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-11 19:19 [PATCH] rt2x00: RT2X00_LIB_RFKILL should depend on INPUT Ivo van Doorn
2008-06-11 20:01 ` Ivo van Doorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).