* [PATCH] ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs
@ 2008-06-13 8:47 Michael Buesch
2008-06-13 14:50 ` Larry Finger
2008-06-13 14:56 ` Michael Buesch
0 siblings, 2 replies; 3+ messages in thread
From: Michael Buesch @ 2008-06-13 8:47 UTC (permalink / raw)
To: John Linville; +Cc: bcm43xx-dev, linux-wireless, Larry Finger
From: Larry.Finger@lwfinger.net
In current ssb-sprom code, the Subsystem and Product ID's are wrong for rev 4
SPROM's.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
John, this is a bugfix for 2.6.26.
Index: ssb_sprom/ssb_sprom.h
===================================================================
--- ssb_sprom.orig/ssb_sprom.h
+++ ssb_sprom/ssb_sprom.h
@@ -33,10 +33,10 @@
/* byte offsets */
#define SPROM_SUBP (0x02 * 2)
-#define SPROM4_SUBP (0x00 * 2)
+#define SPROM4_SUBP (0x02 * 2)
#define SPROM_SUBV (0x03 * 2)
#define SPROM_PPID (0x04 * 2)
-#define SPROM4_PPID (0x02 * 2)
+#define SPROM4_PPID (0x04 * 2)
#define SPROM_BFLHI (0x1C * 2)
#define SPROM_IL0MACADDR (0x24 * 2)
#define SPROM_ET0MACADDR (0x27 * 2)
--
Greetings Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs
2008-06-13 8:47 [PATCH] ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs Michael Buesch
@ 2008-06-13 14:50 ` Larry Finger
2008-06-13 14:56 ` Michael Buesch
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2008-06-13 14:50 UTC (permalink / raw)
To: Michael Buesch; +Cc: John Linville, bcm43xx-dev, linux-wireless
Michael Buesch wrote:
> From: Larry.Finger@lwfinger.net
>
> In current ssb-sprom code, the Subsystem and Product ID's are wrong for rev 4
> SPROM's.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
> ---
>
> John, this is a bugfix for 2.6.26.
>
>
> Index: ssb_sprom/ssb_sprom.h
> ===================================================================
> --- ssb_sprom.orig/ssb_sprom.h
> +++ ssb_sprom/ssb_sprom.h
> @@ -33,10 +33,10 @@
>
> /* byte offsets */
> #define SPROM_SUBP (0x02 * 2)
> -#define SPROM4_SUBP (0x00 * 2)
> +#define SPROM4_SUBP (0x02 * 2)
> #define SPROM_SUBV (0x03 * 2)
> #define SPROM_PPID (0x04 * 2)
> -#define SPROM4_PPID (0x02 * 2)
> +#define SPROM4_PPID (0x04 * 2)
> #define SPROM_BFLHI (0x1C * 2)
> #define SPROM_IL0MACADDR (0x24 * 2)
> #define SPROM_ET0MACADDR (0x27 * 2)
>
The patch is for ssb-sprom, not ssb. If I still have any of my feeble
mind left, ssb-sprom has not become part of the kernel. John, you can
ignore this patch.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs
2008-06-13 8:47 [PATCH] ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs Michael Buesch
2008-06-13 14:50 ` Larry Finger
@ 2008-06-13 14:56 ` Michael Buesch
1 sibling, 0 replies; 3+ messages in thread
From: Michael Buesch @ 2008-06-13 14:56 UTC (permalink / raw)
To: bcm43xx-dev; +Cc: John Linville, linux-wireless, Larry Finger
On Friday 13 June 2008 10:47:33 Michael Buesch wrote:
> From: Larry.Finger@lwfinger.net
>
> In current ssb-sprom code, the Subsystem and Product ID's are wrong for rev 4
> SPROM's.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
> ---
>
> John, this is a bugfix for 2.6.26.
>
>
> Index: ssb_sprom/ssb_sprom.h
> ===================================================================
> --- ssb_sprom.orig/ssb_sprom.h
> +++ ssb_sprom/ssb_sprom.h
Oh, this changes the ssb userland tool. So I better apply it instead
of sending it to random unrelated people :P
> @@ -33,10 +33,10 @@
>
> /* byte offsets */
> #define SPROM_SUBP (0x02 * 2)
> -#define SPROM4_SUBP (0x00 * 2)
> +#define SPROM4_SUBP (0x02 * 2)
> #define SPROM_SUBV (0x03 * 2)
> #define SPROM_PPID (0x04 * 2)
> -#define SPROM4_PPID (0x02 * 2)
> +#define SPROM4_PPID (0x04 * 2)
> #define SPROM_BFLHI (0x1C * 2)
> #define SPROM_IL0MACADDR (0x24 * 2)
> #define SPROM_ET0MACADDR (0x27 * 2)
>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-13 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-13 8:47 [PATCH] ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs Michael Buesch
2008-06-13 14:50 ` Larry Finger
2008-06-13 14:56 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).