* [PATCH] b43legacy: Do not return TX_BUSY from op_tx
@ 2008-06-15 13:27 Michael Buesch
0 siblings, 0 replies; only message in thread
From: Michael Buesch @ 2008-06-15 13:27 UTC (permalink / raw)
To: John Linville; +Cc: bcm43xx-dev, linux-wireless, Stefano Brivio
Never return TX_BUSY from op_tx. It doesn't make sense to return
TX_BUSY, if we can not transmit the packet.
Drop the packet and return TX_OK.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
John, this is a bugfix for 2.6.26.
Index: wireless-testing/drivers/net/wireless/b43legacy/main.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43legacy/main.c 2008-06-06 15:54:17.000000000 +0200
+++ wireless-testing/drivers/net/wireless/b43legacy/main.c 2008-06-15 15:22:37.000000000 +0200
@@ -2374,14 +2374,16 @@ static int b43legacy_op_tx(struct ieee80
spin_lock_irqsave(&wl->irq_lock, flags);
err = b43legacy_pio_tx(dev, skb);
spin_unlock_irqrestore(&wl->irq_lock, flags);
} else
err = b43legacy_dma_tx(dev, skb);
out:
- if (unlikely(err))
- return NETDEV_TX_BUSY;
+ if (unlikely(err)) {
+ /* Drop the packet. */
+ dev_kfree_skb_any(skb);
+ }
return NETDEV_TX_OK;
}
static int b43legacy_op_conf_tx(struct ieee80211_hw *hw, u16 queue,
const struct ieee80211_tx_queue_params *params)
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-06-15 13:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-15 13:27 [PATCH] b43legacy: Do not return TX_BUSY from op_tx Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).