From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Michael Buesch <mb@bu3sch.de>,
linux-wireless <linux-wireless@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2.6.26 (resend)] mac80211: detect driver tx bugs
Date: Wed, 18 Jun 2008 16:37:14 -0400 [thread overview]
Message-ID: <20080618203714.GA20451@tuxdriver.com> (raw)
In-Reply-To: <1213785045.1312.12.camel@johannes.berg>
On Wed, Jun 18, 2008 at 12:30:45PM +0200, Johannes Berg wrote:
> When a driver rejects a frame in it's ->tx() callback, it must also
> stop queues, otherwise mac80211 can go into a loop here. Detect this
> situation and abort the loop after five retries, warning about the
> driver bug.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> This is a port of the patch to 2.6.26 which seems to suffer from the
> same problem and could well be the cause of some of the mac80211 softlockup
> warnings on kerneloops.org.
>
> Dave, with John on vacation until the 22nd, would you push this to Linus
> with the next net update instead of it going through John's tree first?
This is fine with me. Otherwise I'll try to get to it in the next
day or so.
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-06-18 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 12:47 [PATCH] mac80211: detect driver tx bugs Johannes Berg
2008-06-15 12:55 ` [PATCH v2] " Johannes Berg
2008-06-16 1:17 ` Rafael J. Wysocki
2008-06-16 23:23 ` Rafael J. Wysocki
2008-06-17 6:56 ` [PATCH 2.6.26] " Johannes Berg
[not found] ` <1213785045.1312.12.camel@johannes.berg>
2008-06-18 20:37 ` John W. Linville [this message]
2008-06-18 22:38 ` [PATCH 2.6.26 (resend)] " David Miller
2008-06-18 22:40 ` David Miller
2008-06-15 13:49 ` [PATCH] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080618203714.GA20451@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).