From: Marc Pignat <marc.pignat@hevs.ch>
To: libertas-dev@lists.infradead.org
Cc: Holger Schurig <hs4233@mail.mn-solutions.de>,
"John W. Linville" <linville@tuxdriver.com>,
Dan Williams <dcbw@redhat.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] libertas: make mesh code configurable
Date: Fri, 20 Jun 2008 08:48:27 +0200 [thread overview]
Message-ID: <200806200848.28077.marc.pignat@hevs.ch> (raw)
In-Reply-To: <200806191704.10297.hs4233@mail.mn-solutions.de>
Hi!
On Thursday 19 June 2008, Holger Schurig wrote:
> There are no known firmwares for CF and SDIO based devices that
> support MESH. For those devices, mesh-support in the driver is just
> a bit of bloat. Moreover, they're mostly used in embedded devices,
> where space counts.
>
> This patch saves about 10 kB in .text and 288 bytes in .data:
>
> 129542 4012 28 133582 209ce libertas.ko
> 119279 3724 28 123031 1e097 nomesh/libertas.ko
>
> 8142 840 0 8982 2316 libertas_cs.ko
> 8134 840 0 8974 230e nomesh/libertas_cs.ko
>
> 9516 700 8 10224 27f0 libertas_sdio.ko
> 9516 700 8 10224 27f0 nomesh/libertas_sdio.ko
>
> 10333 860 0 11193 2bb9 usb8xxx.ko
> 10333 860 0 11193 2bb9 nomesh/usb8xxx.ko
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Looking at the numbers, this seems a good idea.
But, looking at the code, there are so many #ifdefs!
These #ifdefs have a cost:
* #ifdefs decrease code readability
* every future patch should be (compile AND runtime) tested with the mesh
code enable and disable.
IHMO, the cost versus benefits is far to high.
Best regards
Marc
prev parent reply other threads:[~2008-06-20 7:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 15:04 [PATCH] libertas: make mesh code configurable Holger Schurig
2008-06-19 15:32 ` Johannes Berg
2008-06-20 7:06 ` Holger Schurig
2008-06-20 7:11 ` Johannes Berg
2008-06-19 15:38 ` Johannes Berg
2008-06-20 7:11 ` Holger Schurig
2008-06-20 6:48 ` Marc Pignat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806200848.28077.marc.pignat@hevs.ch \
--to=marc.pignat@hevs.ch \
--cc=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).