[PATCH 0/4] Minor WEXT fixes

[PATCH 0/4] Minor WEXT fixes

[Tomas Winkler]

Few minor WEXT fixes


---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[PATCH 1/4] mac80211: don't return -EINVAL upon iwconfig wlan0 rts auto

[Tomas Winkler]

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

This patch avoids returning -EINVAL upon iwconfig wlan0 rts auto. If
rts->fixed is 0, then we should choose a default value instead of failing.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 net/mac80211/wext.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/wext.c b/net/mac80211/wext.c
index 5af3862..53f8767 100644
--- a/net/mac80211/wext.c
+++ b/net/mac80211/wext.c
@@ -721,6 +721,9 @@ static int ieee80211_ioctl_siwrts(struct net_device *dev,
 
 	if (rts->disabled)
 		local->rts_threshold = IEEE80211_MAX_RTS_THRESHOLD;
+	else if (!rts->fixed)
+		/* if the rts value is not fixed, then take default */
+		local->rts_threshold = IEEE80211_MAX_RTS_THRESHOLD;
 	else if (rts->value < 0 || rts->value > IEEE80211_MAX_RTS_THRESHOLD)
 		return -EINVAL;
 	else
-- 
1.5.4.1

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[PATCH 2/4] mac80211: update the authentication method

[Tomas Winkler]

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

This patch updates the authentication method upon giwencode ioctl.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 net/mac80211/wext.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/wext.c b/net/mac80211/wext.c
index 53f8767..308b953 100644
--- a/net/mac80211/wext.c
+++ b/net/mac80211/wext.c
@@ -952,6 +952,19 @@ static int ieee80211_ioctl_giwencode(struct net_device *dev,
 	erq->length = sdata->keys[idx]->conf.keylen;
 	erq->flags |= IW_ENCODE_ENABLED;
 
+	if (sdata->vif.type == IEEE80211_IF_TYPE_STA) {
+		struct ieee80211_if_sta *ifsta = &sdata->u.sta;
+		switch (ifsta->auth_alg) {
+		case WLAN_AUTH_OPEN:
+		case WLAN_AUTH_LEAP:
+			erq->flags |= IW_ENCODE_OPEN;
+			break;
+		case WLAN_AUTH_SHARED_KEY:
+			erq->flags |= IW_ENCODE_RESTRICTED;
+			break;
+		}
+	}
+
 	return 0;
 }
 
-- 
1.5.4.1

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[PATCH 3/4] mac80211: add last beacon time in scan list

[Tomas Winkler]

From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

This patch adds the interval between the scan results and the last time a
beacon was received in the result of the scan.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 net/mac80211/mlme.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 55659a7..8bfdac7 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -4255,6 +4255,13 @@ ieee80211_sta_scan_result(struct net_device *dev,
 			iwe.u.data.length = strlen(buf);
 			current_ev = iwe_stream_add_point(current_ev, end_buf,
 							  &iwe, buf);
+			memset(&iwe, 0, sizeof(iwe));
+			iwe.cmd = IWEVCUSTOM;
+			sprintf(buf, " Last beacon: %dms ago",
+				jiffies_to_msecs(jiffies - bss->last_update));
+			iwe.u.data.length = strlen(buf);
+			current_ev = iwe_stream_add_point(current_ev, end_buf,
+							  &iwe, buf);
 			kfree(buf);
 		}
 	}
-- 
1.5.4.1

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[PATCH 4/4] mac80211: add phy information to giwname

[Tomas Winkler]

This patch add phy information to giwname. Currently
802.11b is not treated.

Quoting:
It's not useless, it's supposed to tell you about the protocol
capability of the device, like "IEEE 802.11b" or "IEEE 802.11abg"

Jean

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 net/mac80211/wext.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/wext.c b/net/mac80211/wext.c
index 308b953..8778c7d 100644
--- a/net/mac80211/wext.c
+++ b/net/mac80211/wext.c
@@ -135,7 +135,24 @@ static int ieee80211_ioctl_giwname(struct net_device *dev,
 				   struct iw_request_info *info,
 				   char *name, char *extra)
 {
+	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
+	struct ieee80211_supported_band *sband;
+	u8 is_ht = 0;
+
 	strcpy(name, "IEEE 802.11");
+	sband = local->hw.wiphy->bands[IEEE80211_BAND_5GHZ];
+
+	if (sband) {
+		strcat(name, "a");
+		is_ht |= sband->ht_info.ht_supported;
+	}
+	sband = local->hw.wiphy->bands[IEEE80211_BAND_2GHZ];
+	if (sband) {
+		strcat(name, "g");
+		is_ht |= sband->ht_info.ht_supported;
+	}
+	if (is_ht)
+		strcat(name, "n");
 
 	return 0;
 }
-- 
1.5.4.1

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Michael Buesch]

On Tuesday 24 June 2008 12:38:01 Tomas Winkler wrote:
> This patch add phy information to giwname. Currently
> 802.11b is not treated.
> 
> Quoting:
> It's not useless, it's supposed to tell you about the protocol
> capability of the device, like "IEEE 802.11b" or "IEEE 802.11abg"

Well, I think it _is_ pretty useless.
However...

> @@ -135,7 +135,24 @@ static int ieee80211_ioctl_giwname(struct net_device *dev,
>  				   struct iw_request_info *info,
>  				   char *name, char *extra)
>  {
> +	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> +	struct ieee80211_supported_band *sband;
> +	u8 is_ht = 0;
> +
>  	strcpy(name, "IEEE 802.11");
> +	sband = local->hw.wiphy->bands[IEEE80211_BAND_5GHZ];
> +
> +	if (sband) {
> +		strcat(name, "a");
> +		is_ht |= sband->ht_info.ht_supported;
> +	}
> +	sband = local->hw.wiphy->bands[IEEE80211_BAND_2GHZ];
> +	if (sband) {
> +		strcat(name, "g");
> +		is_ht |= sband->ht_info.ht_supported;

What about b-only devices?

> +	}
> +	if (is_ht)
> +		strcat(name, "n");
>  
>  	return 0;
>  }



-- 
Greetings Michael.

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On Tue, 2008-06-24 at 12:42 +0200, Michael Buesch wrote:
> On Tuesday 24 June 2008 12:38:01 Tomas Winkler wrote:
> > This patch add phy information to giwname. Currently
> > 802.11b is not treated.
> > 
> > Quoting:
> > It's not useless, it's supposed to tell you about the protocol
> > capability of the device, like "IEEE 802.11b" or "IEEE 802.11abg"
> 
> Well, I think it _is_ pretty useless.

I agree. Nobody uses this information.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Tomas Winkler]

On Tue, Jun 24, 2008 at 1:42 PM, Michael Buesch <mb@bu3sch.de> wrote:
> On Tuesday 24 June 2008 12:38:01 Tomas Winkler wrote:
>> This patch add phy information to giwname. Currently
>> 802.11b is not treated.
>>
>> Quoting:
>> It's not useless, it's supposed to tell you about the protocol
>> capability of the device, like "IEEE 802.11b" or "IEEE 802.11abg"
>
> Well, I think it _is_ pretty useless.
> However...
>
Still many people are using wireless extension and this is probably
most convenient way to get this info.
For example 4956 comes with 3 combinations g, ag, and agn.
It's displayed upon iwconfig

>> @@ -135,7 +135,24 @@ static int ieee80211_ioctl_giwname(struct net_device *dev,
>>                                  struct iw_request_info *info,
>>                                  char *name, char *extra)
>>  {
>> +     struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
>> +     struct ieee80211_supported_band *sband;
>> +     u8 is_ht = 0;
>> +
>>       strcpy(name, "IEEE 802.11");
>> +     sband = local->hw.wiphy->bands[IEEE80211_BAND_5GHZ];
>> +
>> +     if (sband) {
>> +             strcat(name, "a");
>> +             is_ht |= sband->ht_info.ht_supported;
>> +     }
>> +     sband = local->hw.wiphy->bands[IEEE80211_BAND_2GHZ];
>> +     if (sband) {
>> +             strcat(name, "g");
>> +             is_ht |= sband->ht_info.ht_supported;
>
> What about b-only devices?

See the log message...(known issue). Currently you have to loop over
rates to get this info. I wasn't sure if they are any b-only NICs
under mac80211 so I didn't run to implement it.
>
>> +     }
>> +     if (is_ht)
>> +             strcat(name, "n");
>>
>>       return 0;
>>  }
>
>
>
> --
> Greetings Michael.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]


> Still many people are using wireless extension and this is probably
> most convenient way to get this info.
> For example 4956 comes with 3 combinations g, ag, and agn.
> It's displayed upon iwconfig

Heh ok. I would just say "print out the rates" but I guess that doesn't
work with HT yet.

> >> +             strcat(name, "g");
> >> +             is_ht |= sband->ht_info.ht_supported;
> >
> > What about b-only devices?
> 
> See the log message...(known issue). Currently you have to loop over
> rates to get this info. I wasn't sure if they are any b-only NICs
> under mac80211 so I didn't run to implement it.

There is, adm8211.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Tomas Winkler]

On Tue, Jun 24, 2008 at 2:03 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
>> Still many people are using wireless extension and this is probably
>> most convenient way to get this info.
>> For example 4956 comes with 3 combinations g, ag, and agn.
>> It's displayed upon iwconfig
>
> Heh ok. I would just say "print out the rates" but I guess that doesn't
> work with HT yet.
>
>> >> +             strcat(name, "g");
>> >> +             is_ht |= sband->ht_info.ht_supported;
>> >
>> > What about b-only devices?
>>
>> See the log message...(known issue). Currently you have to loop over
>> rates to get this info. I wasn't sure if they are any b-only NICs
>> under mac80211 so I didn't run to implement it.
>
> There is, adm8211.

Okay I will send a patch on top of this one.
Thanks
Tomas

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Michael Buesch]

On Tuesday 24 June 2008 12:54:25 Tomas Winkler wrote:
> See the log message...(known issue). Currently you have to loop over
> rates to get this info. I wasn't sure if they are any b-only NICs
> under mac80211 so I didn't run to implement it.

b43legacy.
I'd say we either implement it correctly or not at all.
Everything else will only confuse users and generate useless noise
on the lists.

-- 
Greetings Michael.

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Tomas Winkler]

On Tue, Jun 24, 2008 at 2:08 PM, Michael Buesch <mb@bu3sch.de> wrote:
> On Tuesday 24 June 2008 12:54:25 Tomas Winkler wrote:
>> See the log message...(known issue). Currently you have to loop over
>> rates to get this info. I wasn't sure if they are any b-only NICs
>> under mac80211 so I didn't run to implement it.
>
> b43legacy.
> I'd say we either implement it correctly or not at all.
> Everything else will only confuse users and generate useless noise
> on the lists.

Fair enough, I will resend the patch.

Tomas

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Kalle Valo]

Tomas Winkler <tomasw@gmail.com> writes:

>> What about b-only devices?
>
> See the log message...(known issue). Currently you have to loop over
> rates to get this info. I wasn't sure if they are any b-only NICs
> under mac80211 so I didn't run to implement it.

at76_usb will be 11b only mac80211 driver whenever we manage to
complete the port.

-- 
Kalle Valo

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Tomas Winkler]

On Tue, Jun 24, 2008 at 5:03 PM, Kalle Valo <kalle.valo@iki.fi> wrote:
> Tomas Winkler <tomasw@gmail.com> writes:
>
>>> What about b-only devices?
>>
>> See the log message...(known issue). Currently you have to loop over
>> rates to get this info. I wasn't sure if they are any b-only NICs
>> under mac80211 so I didn't run to implement it.
>
> at76_usb will be 11b only mac80211 driver whenever we manage to
> complete the port.
>
> --
> Kalle Valo
>

Then pls, look at the V2 of this patch if this work for you.
Thanks
Tomas

Re: [PATCH 4/4] mac80211: add phy information to giwname

[Kalle Valo]

"Tomas Winkler" <tomasw@gmail.com> writes:

> On Tue, Jun 24, 2008 at 5:03 PM, Kalle Valo <kalle.valo@iki.fi> wrote:
>> Tomas Winkler <tomasw@gmail.com> writes:
>>
>>>> What about b-only devices?
>>>
>>> See the log message...(known issue). Currently you have to loop over
>>> rates to get this info. I wasn't sure if they are any b-only NICs
>>> under mac80211 so I didn't run to implement it.
>>
>> at76_usb will be 11b only mac80211 driver whenever we manage to
>> complete the port.
>
> Then pls, look at the V2 of this patch if this work for you.

I haven't worked with at76_usb in a long time. But if I find time, I
can test this. But it might take a while :(

-- 
Kalle Valo

Re: [PATCH 3/4] mac80211: add last beacon time in scan list

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

On Tue, 2008-06-24 at 13:38 +0300, Tomas Winkler wrote:
> From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> 
> This patch adds the interval between the scan results and the last time a
> beacon was received in the result of the scan.

Why do we need this?


> +			memset(&iwe, 0, sizeof(iwe));
> +			iwe.cmd = IWEVCUSTOM;
> +			sprintf(buf, " Last beacon: %dms ago",
> +				jiffies_to_msecs(jiffies - bss->last_update));

Is there no time_between() or something that accounts for wraparound?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 3/4] mac80211: add last beacon time in scan list

[Dan Williams]

On Tue, 2008-06-24 at 12:47 +0200, Johannes Berg wrote:
> On Tue, 2008-06-24 at 13:38 +0300, Tomas Winkler wrote:
> > From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> > 
> > This patch adds the interval between the scan results and the last time a
> > beacon was received in the result of the scan.
> 
> Why do we need this?

Sometimes it's nice to see when the beacon was last seen, since the
driver holds onto BSSs for a while, you don't know how long they've been
in the scan list.  If you only cared about the newest BSSs you could use
this to ignore certain APs from the scan list.

Would be nice to push this attribute back with nl80211 as well.

Dan

> 
> > +			memset(&iwe, 0, sizeof(iwe));
> > +			iwe.cmd = IWEVCUSTOM;
> > +			sprintf(buf, " Last beacon: %dms ago",
> > +				jiffies_to_msecs(jiffies - bss->last_update));
> 
> Is there no time_between() or something that accounts for wraparound?
> 
> johannes

Re: [PATCH 3/4] mac80211: add last beacon time in scan list

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

On Tue, 2008-06-24 at 07:09 -0400, Dan Williams wrote:
> On Tue, 2008-06-24 at 12:47 +0200, Johannes Berg wrote:
> > On Tue, 2008-06-24 at 13:38 +0300, Tomas Winkler wrote:
> > > From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> > > 
> > > This patch adds the interval between the scan results and the last time a
> > > beacon was received in the result of the scan.
> > 
> > Why do we need this?
> 
> Sometimes it's nice to see when the beacon was last seen, since the
> driver holds onto BSSs for a while, you don't know how long they've been
> in the scan list.  If you only cared about the newest BSSs you could use
> this to ignore certain APs from the scan list.

Well, but you can't really do it in a program since it's a custom type,
or you'd have to parse this.

> Would be nice to push this attribute back with nl80211 as well.

If anybody ever implements anything there...

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 3/4] mac80211: add last beacon time in scan list

[Tomas Winkler]

On Tue, Jun 24, 2008 at 1:47 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Tue, 2008-06-24 at 13:38 +0300, Tomas Winkler wrote:
>> From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>>
>> This patch adds the interval between the scan results and the last time a
>> beacon was received in the result of the scan.
>
> Why do we need this?

Not sure myself I already forgotten who asked me to do it. Maybe some
roaming algorithm needs it in the user space.
>
>> +                     memset(&iwe, 0, sizeof(iwe));
>> +                     iwe.cmd = IWEVCUSTOM;
>> +                     sprintf(buf, " Last beacon: %dms ago",
>> +                             jiffies_to_msecs(jiffies - bss->last_update));
>
> Is there no time_between() or something that accounts for wraparound?

Will fix it.
Thanks
Tomas

Re: [PATCH 2/4] mac80211: update the authentication method

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]

On Tue, 2008-06-24 at 13:37 +0300, Tomas Winkler wrote:
> From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> 
> This patch updates the authentication method upon giwencode ioctl.

Out of curiosity, are you using this?? Or are you just trying to
increase WEXT coverage for some reason? Anyway, it seems like it should
be there.

> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Acked-by: Johannes Berg <johannes@sipsolutions.net>
> ---
>  net/mac80211/wext.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/wext.c b/net/mac80211/wext.c
> index 53f8767..308b953 100644
> --- a/net/mac80211/wext.c
> +++ b/net/mac80211/wext.c
> @@ -952,6 +952,19 @@ static int ieee80211_ioctl_giwencode(struct net_device *dev,
>  	erq->length = sdata->keys[idx]->conf.keylen;
>  	erq->flags |= IW_ENCODE_ENABLED;
>  
> +	if (sdata->vif.type == IEEE80211_IF_TYPE_STA) {
> +		struct ieee80211_if_sta *ifsta = &sdata->u.sta;
> +		switch (ifsta->auth_alg) {
> +		case WLAN_AUTH_OPEN:
> +		case WLAN_AUTH_LEAP:
> +			erq->flags |= IW_ENCODE_OPEN;
> +			break;
> +		case WLAN_AUTH_SHARED_KEY:
> +			erq->flags |= IW_ENCODE_RESTRICTED;
> +			break;
> +		}
> +	}
> +
>  	return 0;
>  }
>  

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/4] mac80211: update the authentication method

[Dan Williams]

On Tue, 2008-06-24 at 13:37 +0300, Tomas Winkler wrote:
> From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> 
> This patch updates the authentication method upon giwencode ioctl.
> 
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Acked-by: Dan Williams <dcbw@redhat.com>

> ---
>  net/mac80211/wext.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/wext.c b/net/mac80211/wext.c
> index 53f8767..308b953 100644
> --- a/net/mac80211/wext.c
> +++ b/net/mac80211/wext.c
> @@ -952,6 +952,19 @@ static int ieee80211_ioctl_giwencode(struct net_device *dev,
>  	erq->length = sdata->keys[idx]->conf.keylen;
>  	erq->flags |= IW_ENCODE_ENABLED;
>  
> +	if (sdata->vif.type == IEEE80211_IF_TYPE_STA) {
> +		struct ieee80211_if_sta *ifsta = &sdata->u.sta;
> +		switch (ifsta->auth_alg) {
> +		case WLAN_AUTH_OPEN:
> +		case WLAN_AUTH_LEAP:
> +			erq->flags |= IW_ENCODE_OPEN;
> +			break;
> +		case WLAN_AUTH_SHARED_KEY:
> +			erq->flags |= IW_ENCODE_RESTRICTED;
> +			break;
> +		}
> +	}
> +
>  	return 0;
>  }
>  

Re: [PATCH 1/4] mac80211: don't return -EINVAL upon iwconfig wlan0 rts auto

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On Tue, 2008-06-24 at 13:37 +0300, Tomas Winkler wrote:
> From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> 
> This patch avoids returning -EINVAL upon iwconfig wlan0 rts auto. If
> rts->fixed is 0, then we should choose a default value instead of failing.
> 
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> ---
>  net/mac80211/wext.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/wext.c b/net/mac80211/wext.c
> index 5af3862..53f8767 100644
> --- a/net/mac80211/wext.c
> +++ b/net/mac80211/wext.c
> @@ -721,6 +721,9 @@ static int ieee80211_ioctl_siwrts(struct net_device *dev,
>  
>  	if (rts->disabled)
>  		local->rts_threshold = IEEE80211_MAX_RTS_THRESHOLD;
> +	else if (!rts->fixed)
> +		/* if the rts value is not fixed, then take default */
> +		local->rts_threshold = IEEE80211_MAX_RTS_THRESHOLD;
>  	else if (rts->value < 0 || rts->value > IEEE80211_MAX_RTS_THRESHOLD)
>  		return -EINVAL;
>  	else

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]