From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: drago01 <drago01@gmail.com>
Cc: Linux Wireless <linux-wireless@vger.kernel.org>,
Ivo van Doorn <ivdoorn@gmail.com>, "Zhu, Yi" <yi.zhu@intel.com>,
Tomas Winkler <tomas.winkler@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
Dan Williams <dcbw@redhat.com>
Subject: Re: [PATCHv2] iwl3945: add support for RFKILL_STATE_HARD_BLOCKED
Date: Sat, 28 Jun 2008 11:12:37 -0300 [thread overview]
Message-ID: <20080628141237.GD871@khazad-dum.debian.net> (raw)
In-Reply-To: <f6ca9fed0806280651w48cac49ew8fd29b4d8dddaa0c@mail.gmail.com>
On Sat, 28 Jun 2008, drago01 wrote:
> On Sat, Jun 28, 2008 at 3:17 PM, Henrique de Moraes Holschuh
> <hmh@hmh.eng.br> wrote:
> > On Sat, 28 Jun 2008, drago01 wrote:
> >> This patch fixes the rfkill states to set RFKILL_STATE_HARD_BLOCKED when the
> >> radio is disabled by a hardware killswitch.
> >> It does not allow setting the sw state while the device is blocked by
> >> a hardware rfkill switch.
> >
> > See my comment on your other patch, the device should be able to
> > double-block.
>
> OK, see attached patch.
Looks good, same caveat as the other one: I don't know the driver.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
prev parent reply other threads:[~2008-06-28 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 8:15 [PATCH] iwl3945: add support for RFKILL_STATE_HARD_BLOCKED drago01
2008-06-28 13:17 ` Henrique de Moraes Holschuh
2008-06-28 13:51 ` [PATCHv2] " drago01
2008-06-28 14:12 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080628141237.GD871@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=dcbw@redhat.com \
--cc=drago01@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomas.winkler@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).