Re: [PATCH/RFC] b43: remove input device usage for rfkill

[Michael Buesch <mb@bu3sch.de>]

On Tuesday 01 July 2008 12:33:17 drago01 wrote:
> On Tue, Jul 1, 2008 at 12:27 PM, Michael Buesch <mb@bu3sch.de> wrote:
> > On Tuesday 01 July 2008 11:55:11 Adel Gadllah wrote:
> >> Hi,
> >> The attached patch removes the input device dependency and replaces
> >> the polldev by a timer.
> >> The timer polls the device and sets the rfkill state.
> >> I build tested the patch only because I don't have access to the
> >> hardware, hence the RFC.
> >> Can someone with the access to the hardware test and verify this?
> >> If it works I will submit a similar patch for b43legacy.
> >>
> >> -----------------------
> >> This patch removes the dependency on the input device and replaces the
> >> polldev with a timer for polling the rfkill state.
> >
> >
> > I'm pretty sure this will generate a lot of bugreports complaining that
> > rfkill silently broke, as the userspace is not setup correctly.
> 
> OK, so how to proceed? Just leave the input device?

No well. This probably is the right way to go. However I just wanted to
say that I'm pretty sure it will generate lots of bugreports that I
will ignore. ;)

But I am wondering _why_ we need to turn all this upside down.
What's so bad about having an input device in the kernel? What's the
advantage of having userspace do the work?

-- 
Greetings Michael.