[PATCH 1/1] mac80211: remove useless tid assignment for management and control frames

[PATCH 1/1] mac80211: remove useless tid assignment for management and control frames

[Tomas Winkler]

This patch removes useless tid assignment for management and control frames

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 net/mac80211/wme.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/wme.c b/net/mac80211/wme.c
index f23b5a4..30d3b5b 100644
--- a/net/mac80211/wme.c
+++ b/net/mac80211/wme.c
@@ -210,7 +210,6 @@ static int wme_qdiscop_enqueue(struct sk_buff *skb, struct Qdisc* qd)
 			kfree_skb(skb);
 			err = NET_XMIT_DROP;
 	} else {
-		tid = skb->priority & QOS_CONTROL_TAG1D_MASK;
 		skb_set_queue_mapping(skb, queue);
 		qdisc = q->queues[queue];
 		err = qdisc->enqueue(skb, qdisc);
-- 
1.5.4.1

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[PATCH 1/1] mac80211: remove usless tid assignment for managment and control frames

[Tomas Winkler]

This patch removes useless tid assignment for management and control frames

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 net/mac80211/wme.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/wme.c b/net/mac80211/wme.c
index f23b5a4..30d3b5b 100644
--- a/net/mac80211/wme.c
+++ b/net/mac80211/wme.c
@@ -210,7 +210,6 @@ static int wme_qdiscop_enqueue(struct sk_buff *skb, struct Qdisc* qd)
 			kfree_skb(skb);
 			err = NET_XMIT_DROP;
 	} else {
-		tid = skb->priority & QOS_CONTROL_TAG1D_MASK;
 		skb_set_queue_mapping(skb, queue);
 		qdisc = q->queues[queue];
 		err = qdisc->enqueue(skb, qdisc);
-- 
1.5.4.1

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [PATCH 1/1] mac80211: remove usless tid assignment for managment and control frames

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 819 bytes --]

On Tue, 2008-07-01 at 14:29 +0300, Tomas Winkler wrote:
> This patch removes useless tid assignment for management and control frames
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> ---
>  net/mac80211/wme.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/wme.c b/net/mac80211/wme.c
> index f23b5a4..30d3b5b 100644
> --- a/net/mac80211/wme.c
> +++ b/net/mac80211/wme.c
> @@ -210,7 +210,6 @@ static int wme_qdiscop_enqueue(struct sk_buff *skb, struct Qdisc* qd)
>  			kfree_skb(skb);
>  			err = NET_XMIT_DROP;
>  	} else {
> -		tid = skb->priority & QOS_CONTROL_TAG1D_MASK;
>  		skb_set_queue_mapping(skb, queue);
>  		qdisc = q->queues[queue];
>  		err = qdisc->enqueue(skb, qdisc);

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] mac80211: remove usless tid assignment for managment and control frames

[Tomas Winkler]

On Tue, Jul 1, 2008 at 2:32 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Tue, 2008-07-01 at 14:29 +0300, Tomas Winkler wrote:
>> This patch removes useless tid assignment for management and control frames
>>
>> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Acked-by: Johannes Berg <johannes@sipsolutions.net>

I would prefer you ack the version without spelling errors :).

John please discard this one
Tomas

Re: [PATCH 1/1] mac80211: remove usless tid assignment for managment and control frames

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Tue, 2008-07-01 at 14:52 +0300, Tomas Winkler wrote:
> On Tue, Jul 1, 2008 at 2:32 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Tue, 2008-07-01 at 14:29 +0300, Tomas Winkler wrote:
> >> This patch removes useless tid assignment for management and control frames
> >>
> >> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> >
> > Acked-by: Johannes Berg <johannes@sipsolutions.net>
> 
> I would prefer you ack the version without spelling errors :).

Oh! I looked for the difference but didn't find it and so figured you
just sent it out twice accidentally. Feel free to transfer that line to
the other patch.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] mac80211: remove usless tid assignment for managment and control frames

[John W. Linville]

On Tue, Jul 01, 2008 at 02:52:57PM +0300, Tomas Winkler wrote:
> On Tue, Jul 1, 2008 at 2:32 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Tue, 2008-07-01 at 14:29 +0300, Tomas Winkler wrote:
> >> This patch removes useless tid assignment for management and control frames
> >>
> >> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> >
> > Acked-by: Johannes Berg <johannes@sipsolutions.net>
> 
> I would prefer you ack the version without spelling errors :).
> 
> John please discard this one

I like the spelling erros, Tomas.  It makes you seem more human!
But, if you insist... :-)

-- 
John W. Linville
linville@tuxdriver.com