From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Adel Gadllah <adel.gadllah@gmail.com>
Cc: linux-wireless@vger.kernel.org, randy.dunlap@oracle.com,
"John W. Linville" <linville@tuxdriver.com>,
Ivo van Doorn <ivdoorn@gmail.com>,
fcrespel@gmail.com, yi.zhu@intel.com
Subject: Re: [PATCH] iwlwifi: remove input device and fix rfkill state
Date: Tue, 1 Jul 2008 13:56:57 -0300 [thread overview]
Message-ID: <20080701165657.GC6962@khazad-dum.debian.net> (raw)
In-Reply-To: <6cf6b73e0807010849t42de3f3fn68085daca8d8009e@mail.gmail.com>
On Tue, 01 Jul 2008, Adel Gadllah wrote:
> The calls to iwl|iwl3945_rfkill_set_hw_state() had to be moved because
> rfkill_force_state() cannot be called from an atomic context.
Yeah, the joys of mutexes. If this is going to be a severe annoyance to
drivers, I don't see why rfkill could not be changed to use some other
locking primitive that does work on atomic contexes.
But I am not the right person to do it, I am still learning about all
the different locking flavours in Linux.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2008-07-01 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 15:49 [PATCH] iwlwifi: remove input device and fix rfkill state Adel Gadllah
2008-07-01 16:56 ` Henrique de Moraes Holschuh [this message]
2008-07-02 8:25 ` Zhu Yi
2008-07-02 15:43 ` Henrique de Moraes Holschuh
2008-07-02 16:00 ` Ivo van Doorn
2008-07-02 18:41 ` Henrique de Moraes Holschuh
2008-07-02 22:31 ` Ivo van Doorn
2008-07-03 1:53 ` Henrique de Moraes Holschuh
2008-07-03 3:11 ` Zhu Yi
2008-07-03 12:49 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701165657.GC6962@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=adel.gadllah@gmail.com \
--cc=fcrespel@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=randy.dunlap@oracle.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).