From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA
Date: Tue, 1 Jul 2008 16:36:58 -0400 [thread overview]
Message-ID: <20080701203658.GA9225@tuxdriver.com> (raw)
In-Reply-To: <486A9248.9000607@lwfinger.net>
On Tue, Jul 01, 2008 at 03:23:36PM -0500, Larry Finger wrote:
> After the latest wireless-testing update, b43 was unable to connect to
> my WPA network. Bisection leads to the following commit as the culprit:
>
> commit c4438fa71bf412862ed0b73111956b0ffd8209d3
> Author: Harvey Harrison <harvey.harrison@gmail.com>
> Date: Thu Jun 26 13:21:50 2008 -0700
>
> mac80211: remove ieee80211_get_hdr_info
>
> Move the address selection into the michale_mic header calculation
> helper
> and pass a pointer to the ieee80211_hdr directly.
>
> Reorganize ccmp_special_blocks while eliminating the unneeded
> sa/da/qos
> variables.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> :040000 040000 c77af99ab0477f3ec3159af8566fb1de61856ab8
> 7fa906d1d2acc6f9d88b923eed0990b9b14ea830 M net
>
> This commit was confirmed as the problem by reverting it.
Luckily that is just in my "pending" stack. I'll revert it ASAP.
Harvey, you are welcome to resubmit if you can tell us what broke
things! :-)
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-07-01 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 20:23 Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA Larry Finger
2008-07-01 20:36 ` John W. Linville [this message]
2008-07-01 21:14 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701203658.GA9225@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=harvey.harrison@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).