linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA
@ 2008-07-01 20:23 Larry Finger
  2008-07-01 20:36 ` John W. Linville
  0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2008-07-01 20:23 UTC (permalink / raw)
  To: John Linville, Harvey Harrison; +Cc: wireless

After the latest wireless-testing update, b43 was unable to connect to 
my WPA network. Bisection leads to the following commit as the culprit:

commit c4438fa71bf412862ed0b73111956b0ffd8209d3
Author: Harvey Harrison <harvey.harrison@gmail.com>
Date:   Thu Jun 26 13:21:50 2008 -0700

     mac80211: remove ieee80211_get_hdr_info

     Move the address selection into the michale_mic header 
calculation helper
     and pass a pointer to the ieee80211_hdr directly.

     Reorganize ccmp_special_blocks while eliminating the unneeded 
sa/da/qos
     variables.

     Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
     Signed-off-by: John W. Linville <linville@tuxdriver.com>

:040000 040000 c77af99ab0477f3ec3159af8566fb1de61856ab8 
7fa906d1d2acc6f9d88b923eed0990b9b14ea830 M      net

This commit was confirmed as the problem by reverting it.

Larry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA
  2008-07-01 20:23 Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA Larry Finger
@ 2008-07-01 20:36 ` John W. Linville
  2008-07-01 21:14   ` Harvey Harrison
  0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2008-07-01 20:36 UTC (permalink / raw)
  To: Larry Finger; +Cc: Harvey Harrison, wireless

On Tue, Jul 01, 2008 at 03:23:36PM -0500, Larry Finger wrote:
> After the latest wireless-testing update, b43 was unable to connect to  
> my WPA network. Bisection leads to the following commit as the culprit:
>
> commit c4438fa71bf412862ed0b73111956b0ffd8209d3
> Author: Harvey Harrison <harvey.harrison@gmail.com>
> Date:   Thu Jun 26 13:21:50 2008 -0700
>
>     mac80211: remove ieee80211_get_hdr_info
>
>     Move the address selection into the michale_mic header calculation 
> helper
>     and pass a pointer to the ieee80211_hdr directly.
>
>     Reorganize ccmp_special_blocks while eliminating the unneeded  
> sa/da/qos
>     variables.
>
>     Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>     Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> :040000 040000 c77af99ab0477f3ec3159af8566fb1de61856ab8  
> 7fa906d1d2acc6f9d88b923eed0990b9b14ea830 M      net
>
> This commit was confirmed as the problem by reverting it.

Luckily that is just in my "pending" stack.  I'll revert it ASAP.
Harvey, you are welcome to resubmit if you can tell us what broke
things! :-)

John
-- 
John W. Linville
linville@tuxdriver.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA
  2008-07-01 20:36 ` John W. Linville
@ 2008-07-01 21:14   ` Harvey Harrison
  0 siblings, 0 replies; 3+ messages in thread
From: Harvey Harrison @ 2008-07-01 21:14 UTC (permalink / raw)
  To: John W. Linville; +Cc: Larry Finger, wireless

On Tue, 2008-07-01 at 16:36 -0400, John W. Linville wrote:
> On Tue, Jul 01, 2008 at 03:23:36PM -0500, Larry Finger wrote:
> > 7fa906d1d2acc6f9d88b923eed0990b9b14ea830 M      net
> >
> > This commit was confirmed as the problem by reverting it.
> 
> Luckily that is just in my "pending" stack.  I'll revert it ASAP.
> Harvey, you are welcome to resubmit if you can tell us what broke
> things! :-)
> 

Will investigate it this evening.

Harvey


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-07-01 21:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-01 20:23 Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA Larry Finger
2008-07-01 20:36 ` John W. Linville
2008-07-01 21:14   ` Harvey Harrison

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).