From: David Miller <davem@davemloft.net>
To: wangchen@cn.fujitsu.com
Cc: netdev@vger.kernel.org, vinay@linux.vnet.ibm.com,
krkumar2@in.ibm.com, mchan@broadcom.com, Matheos.Worku@Sun.COM,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 06/39]: netdev: ->ingress_lock is no longer needed.
Date: Thu, 03 Jul 2008 03:02:41 -0700 (PDT) [thread overview]
Message-ID: <20080703.030241.34728979.davem@davemloft.net> (raw)
In-Reply-To: <486CA212.6020705@cn.fujitsu.com>
From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Thu, 03 Jul 2008 17:55:30 +0800
> David Miller said the following on 2008-7-3 15:03:
> > @@ -2014,10 +2014,11 @@ static inline struct sk_buff *handle_macvlan(struct sk_buff *skb,
> > */
> > static int ing_filter(struct sk_buff *skb)
> > {
> > - struct Qdisc *q;
> > struct net_device *dev = skb->dev;
> > - int result = TC_ACT_OK;
> > u32 ttl = G_TC_RTTL(skb->tc_verd);
> > + struct netdev_queue *rxq;
> > + int result = TC_ACT_OK;
> > + struct Qdisc *q;
> >
>
> Two lines do not change anything.
They make the variables have a nice style slope from longest
lines to the shortest.
If I'm going to edit this much of the TX path, I'm going to
cleanup coding style details like this along the way.
next prev parent reply other threads:[~2008-07-03 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 7:03 [PATCH 06/39]: netdev: ->ingress_lock is no longer needed David Miller
2008-07-03 9:55 ` Wang Chen
2008-07-03 10:02 ` David Miller [this message]
2008-07-03 10:01 ` Wang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703.030241.34728979.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Matheos.Worku@Sun.COM \
--cc=krkumar2@in.ibm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vinay@linux.vnet.ibm.com \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).