From: David Miller <davem@davemloft.net>
To: khc@pm.waw.pl
Cc: netdev@vger.kernel.org, vinay@linux.vnet.ibm.com,
krkumar2@in.ibm.com, mchan@broadcom.com, Matheos.Worku@Sun.COM,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 26/39]: netdev: netdev_priv() can now be sane again.
Date: Thu, 03 Jul 2008 04:26:14 -0700 (PDT) [thread overview]
Message-ID: <20080703.042614.244608628.davem@davemloft.net> (raw)
In-Reply-To: <m3tzf7nrd7.fsf@maximus.localdomain>
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Thu, 03 Jul 2008 13:23:32 +0200
> David Miller <davem@davemloft.net> writes:
>
> > The private area of a netdev is now at a fixed offset once more.
> >
> > Unfortunately, some assumptions that netdev_priv() == netdev->priv
> > crept back into the tree. In particular this happened in the
> > loopback driver.
>
> Perhaps the netdev_priv() should be renamed to avoid confusion?
If all drivers call netdev_priv(), there is no confusion :)
I plan to rename dev->priv to dev->_priv and fix all the fallout.
next prev parent reply other threads:[~2008-07-03 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 7:04 [PATCH 26/39]: netdev: netdev_priv() can now be sane again David Miller
2008-07-03 11:23 ` Krzysztof Halasa
2008-07-03 11:26 ` David Miller [this message]
2008-07-03 14:18 ` Krzysztof Halasa
2008-07-03 22:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703.042614.244608628.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Matheos.Worku@Sun.COM \
--cc=khc@pm.waw.pl \
--cc=krkumar2@in.ibm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vinay@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox