From: Ivo van Doorn <ivdoorn@gmail.com>
To: linville@tuxdriver.com
Cc: "linux-wireless" <linux-wireless@vger.kernel.org>,
rt2400-devel@lists.sourceforge.net
Subject: [PATCH 2/4] rt2x00: Decrease alignment headroom
Date: Fri, 4 Jul 2008 13:41:29 +0200 [thread overview]
Message-ID: <200807041341.29802.IvDoorn@gmail.com> (raw)
In-Reply-To: <200807041340.28103.IvDoorn@gmail.com>
We only need 4 bytes of headroom for alignment
purposes in the RX frame. It was previously higher
for optimization purposes which are no longer
possible due to DMA mappings.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.c b/drivers/net/wireless/rt2x00/rt2x00queue.c
index 8e86611..3ddce53 100644
--- a/drivers/net/wireless/rt2x00/rt2x00queue.c
+++ b/drivers/net
/wireless/rt2x00/rt2x00queue.c
@@ -45,10 +45,11 @@ struct sk_buff *rt2x00queue_alloc_rxskb(struct rt2x00_dev *rt2x00dev,
frame_size = entry->queue->data_size + entry->queue->desc_size;
/*
- * Reserve a few bytes extra headroom to allow drivers some moving
- * space (e.g. for alignment), while keeping the skb aligned.
+ * The payload should be aligned to a 4-byte boundary,
+ * this means we need at least 3 bytes for moving the frame
+ * into the correct offset.
*/
- reserved_size = 8;
+ reserved_size = 4;
/*
* Allocate skbuffer.
next parent reply other threads:[~2008-07-04 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200807041340.28103.IvDoorn@gmail.com>
2008-07-04 11:41 ` Ivo van Doorn [this message]
2008-07-04 12:56 ` [PATCH 2/4 v2] rt2x00: Decrease alignment headroom Ivo van Doorn
[not found] ` <200807041340.53147.IvDoorn@gmail.com>
2008-07-04 11:41 ` [PATCH 3/4] rt2x00: Use ieee80211_hw->workqueue again Ivo van Doorn
2008-07-04 11:41 ` [PATCH 4/4] rt2x00: Report RX end time for rt2400pci Ivo van Doorn
2008-07-04 11:42 ` Johannes Berg
2008-07-04 12:25 ` Ivo van Doorn
2008-07-04 12:23 ` Johannes Berg
2008-07-04 12:53 ` Ivo van Doorn
2008-07-04 14:14 ` [PATCH 4/4 v2] " Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807041341.29802.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).