From: Milan Plzik <milan.plzik@gmail.com>
To: linux-wireless@vger.kernel.org
Subject: [PATCH 2/7] Don't leave queues stopped when not neccessary.
Date: Fri, 04 Jul 2008 19:44:04 +0200 [thread overview]
Message-ID: <20080704174404.4996.26267.stgit@localhost> (raw)
In-Reply-To: <20080704174350.4996.72931.stgit@localhost>
at76_usb driver doesn't enable transmit queue very often -- in fact the
only place where queues are being started is tx callback handler. This
patch adds calls to ieee80211_start_queues to proper places, so the card
will not hang in state with queues stopped.
Signed-off-by: Milan Plzik <milan.plzik@gmail.com>
---
drivers/net/wireless/at76_usb.c | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/at76_usb.c b/drivers/net/wireless/at76_usb.c
index dc6edb3..13ea9ca 100644
--- a/drivers/net/wireless/at76_usb.c
+++ b/drivers/net/wireless/at76_usb.c
@@ -1910,8 +1910,13 @@ static void at76_dwork_hw_scan(struct work_struct *work)
ieee80211_scan_completed(priv->hw);
- if (is_valid_ether_addr(priv->bssid))
+ if (is_valid_ether_addr(priv->bssid)) {
+ ieee80211_start_queues(priv->hw);
at76_join(priv);
+ } else
+ ieee80211_stop_queues(priv->hw);
+
+ ieee80211_start_queues(priv->hw);
// CHECKME: ieee80211_wake_queues(priv->hw);
@@ -1974,10 +1979,13 @@ static int at76_config(struct ieee80211_hw *hw, struct ieee80211_conf *conf)
priv->channel = conf->channel->hw_value;
- if (is_valid_ether_addr(priv->bssid))
+ if (is_valid_ether_addr(priv->bssid)) {
at76_join(priv);
- else
+ ieee80211_start_queues(priv->hw);
+ } else {
+ ieee80211_stop_queues(priv->hw);
at76_start_monitor(priv);
+ };
mutex_unlock(&priv->mtx);
next prev parent reply other threads:[~2008-07-04 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 17:43 [PATCH 1/7] Fix possible mutex double-locking Milan Plzik
2008-07-04 17:44 ` Milan Plzik [this message]
2008-07-04 17:44 ` [PATCH 3/7] Remove usage of data which were already skb_pull-ed Milan Plzik
2008-07-04 17:44 ` [PATCH 4/7] Some at76-based devices don't include FCS in received frames Milan Plzik
2008-07-04 17:44 ` [PATCH 5/7] Minor final fixes Milan Plzik
2008-07-04 17:44 ` [PATCH 6/7] Adds support for WEP operation with 1.103.x firmware Milan Plzik
2008-07-04 17:44 ` [PATCH 7/7] Add WPA support for 1.103 firmware Milan Plzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080704174404.4996.26267.stgit@localhost \
--to=milan.plzik@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).