From: Michael Buesch <mb@bu3sch.de>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/6] b43legacy: use le16 frame control directly, avoid byteswapping
Date: Wed, 9 Jul 2008 14:47:15 +0200 [thread overview]
Message-ID: <200807091447.15828.mb@bu3sch.de> (raw)
In-Reply-To: <1215550043.476.41.camel@brick>
On Tuesday 08 July 2008 22:47:23 Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
ACK
> ---
> drivers/net/wireless/b43legacy/xmit.c | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/b43legacy/xmit.c b/drivers/net/wireless/b43legacy/xmit.c
> index a354078..5e8a575 100644
> --- a/drivers/net/wireless/b43legacy/xmit.c
> +++ b/drivers/net/wireless/b43legacy/xmit.c
> @@ -193,7 +193,6 @@ static int generate_txhdr_fw3(struct b43legacy_wldev *dev,
> {
> const struct ieee80211_hdr *wlhdr;
> int use_encryption = (!(info->flags & IEEE80211_TX_CTL_DO_NOT_ENCRYPT));
> - u16 fctl;
> u8 rate;
> struct ieee80211_rate *rate_fb;
> int rate_ofdm;
> @@ -204,7 +203,6 @@ static int generate_txhdr_fw3(struct b43legacy_wldev *dev,
> struct ieee80211_rate *tx_rate;
>
> wlhdr = (const struct ieee80211_hdr *)fragment_data;
> - fctl = le16_to_cpu(wlhdr->frame_control);
>
> memset(txhdr, 0, sizeof(*txhdr));
>
> @@ -253,7 +251,7 @@ static int generate_txhdr_fw3(struct b43legacy_wldev *dev,
> mac_ctl |= (key->algorithm <<
> B43legacy_TX4_MAC_KEYALG_SHIFT) &
> B43legacy_TX4_MAC_KEYALG;
> - wlhdr_len = ieee80211_get_hdrlen(fctl);
> + wlhdr_len = ieee80211_hdrlen(wlhdr->frame_control);
> iv_len = min((size_t)info->control.iv_len,
> ARRAY_SIZE(txhdr->iv));
> memcpy(txhdr->iv, ((u8 *)wlhdr) + wlhdr_len, iv_len);
> @@ -295,8 +293,7 @@ static int generate_txhdr_fw3(struct b43legacy_wldev *dev,
> /* MAC control */
> if (!(info->flags & IEEE80211_TX_CTL_NO_ACK))
> mac_ctl |= B43legacy_TX4_MAC_ACK;
> - if (!(((fctl & IEEE80211_FCTL_FTYPE) == IEEE80211_FTYPE_CTL) &&
> - ((fctl & IEEE80211_FCTL_STYPE) == IEEE80211_STYPE_PSPOLL)))
> + if (!ieee80211_is_pspoll(wlhdr->frame_control))
> mac_ctl |= B43legacy_TX4_MAC_HWSEQ;
> if (info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT)
> mac_ctl |= B43legacy_TX4_MAC_STMSDU;
--
Greetings Michael.
prev parent reply other threads:[~2008-07-09 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 20:47 [PATCH 3/6] b43legacy: use le16 frame control directly, avoid byteswapping Harvey Harrison
2008-07-09 12:47 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807091447.15828.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=harvey.harrison@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).