From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
rt2400-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/3] mac80211: Include sequence number in IBSS and Mesh beacons
Date: Wed, 9 Jul 2008 20:12:11 +0200 [thread overview]
Message-ID: <200807092012.11234.IvDoorn@gmail.com> (raw)
In-Reply-To: <1215625355.3246.41.camel@johannes.berg>
On Wednesday 09 July 2008, Johannes Berg wrote:
> On Wed, 2008-07-09 at 18:12 +0200, Ivo van Doorn wrote:
>
> > > I'll put off the fix until after davem's TX MQ rework though.
>
> Actually, I don't have to.
>
> > Ok, that would allow some time for rt2x00 to come up with the
> > implementation for the rt2400pci and rt2500pci drivers.
> >
> > And this is extra motivation for a volunteer to look into this,
> > because when mac80211 removes the seq counting, it is not
> > just adhoc and master mode that are broken. ;)
>
> Here's a patch to try it out:
>
> http://johannes.sipsolutions.net/patches/kernel/all/2008-07-09-17%3a38/022-mac80211-fix-hwseq.patch
Personally I have my doubts about the meaningfullness of the flag
IEEE80211_TX_CTL_QOS_FRAME
since drivers will probably use ieee80211_is_data_qos() instead.
Perhaps it is better to have the flag named something like:
IEEE80211_TX_CTS_SW_SEQUENCE
or
IEEE80211_TX_CTS_HAS_SEQUENCE
That way it is a bit clearer what the intention of the flag is.
Ivo
next prev parent reply other threads:[~2008-07-09 18:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 13:11 [PATCH 0/3] rt2x00 update Ivo van Doorn
2008-07-09 13:11 ` [PATCH 1/3] mac80211: Include sequence number in IBSS and Mesh beacons Ivo van Doorn
2008-07-09 13:12 ` [PATCH 2/3] rt2x00: Add support for CTS protection in rt2x00lib Ivo van Doorn
2008-07-09 13:12 ` [PATCH 3/3] rt2x00: Reorganize beacon handling Ivo van Doorn
2008-07-09 13:14 ` [PATCH 1/3] mac80211: Include sequence number in IBSS and Mesh beacons Johannes Berg
2008-07-09 13:38 ` Michael Buesch
2008-07-09 13:41 ` Johannes Berg
2008-07-09 14:04 ` Ivo van Doorn
2008-07-09 13:58 ` Johannes Berg
2008-07-09 14:57 ` Ivo van Doorn
2008-07-09 14:49 ` Johannes Berg
2008-07-09 14:00 ` Michael Buesch
2008-07-09 14:05 ` Johannes Berg
2008-07-09 14:37 ` Ivo van Doorn
2008-07-09 14:48 ` Johannes Berg
2008-07-09 15:08 ` Ivo van Doorn
2008-07-09 15:15 ` Michael Buesch
2008-07-09 15:36 ` Ivo van Doorn
2008-07-09 15:33 ` Johannes Berg
2008-07-09 15:48 ` Ivo van Doorn
2008-07-09 15:49 ` Johannes Berg
2008-07-09 15:55 ` Johannes Berg
2008-07-09 16:12 ` Ivo van Doorn
2008-07-09 17:42 ` Johannes Berg
2008-07-09 18:12 ` Ivo van Doorn [this message]
2008-07-09 18:07 ` Johannes Berg
2008-07-09 16:08 ` Ivo van Doorn
2008-07-09 16:07 ` Johannes Berg
2008-07-09 15:16 ` Johannes Berg
2008-07-09 15:12 ` Michael Buesch
2008-07-14 18:49 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807092012.11234.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).