linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Hin-Tak Leung" <hintak.leung@gmail.com>,
	Pavel Roskin <proski@gnu.org>,
	linux-wireless@vger.kernel.org
Subject: Re: [RFC/RFT] rtl8187: Improve wireless statistics for RTL8187B
Date: Fri, 18 Jul 2008 21:42:59 -0300	[thread overview]
Message-ID: <200807182142.59921.herton@mandriva.com.br> (raw)
In-Reply-To: <487f5f20.2lT57D3i0q99wrfY%Larry.Finger@lwfinger.net>

Em Thursday 17 July 2008 12:02:56 Larry Finger escreveu:
> Wireless statistics produced by the RTL8187B driver are not particularly
> informative about the strength of the received signal. From the data sheet
> provided by Realtek, I discovered that certain parts of the RX header
> should have the information necessary to calculate signal quality and
> strength. With testing, it became clear that most of these quantities were
> very jittery - only the AGC correlated with the signals expected from
> nearby AP's. As a result, the quality and strength are derived from the agc
> value. The scaling has been determined so that the numbers are close to
> those obtained by b43 under the same conditions. The results are
> qualitatively correct.
>
> Statistics derived for the RTL8187 have not been changed.
>
> The RX header variables have been renamed to match the quantites described
> in the Realtek data sheet.

Hi,

I did some tests here and statistics are better now. I only couldn't use 
latest wireless-testing because something of latest changes broke 
communication, I couldn't scan/associate anymore, but using wireless-testing 
head at d61f20889de4978ed87d2a37d6f27147faec22d1 plus later anaparam*off 
change, with your patch I can confirm the better statistics, later I'll try 
to find what in wireless-testing broke here, I didn't have time to look into 
this today.

>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Pavel,
>
> Please check that this patch does not break the RTL8187 statistics.
> Perhaps, similar changes should be made there, but I don't have the
> hardware.
>
> Larry

-- 
[]'s
Herton

  reply	other threads:[~2008-07-19  0:43 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17 15:02 [RFC/RFT] rtl8187: Improve wireless statistics for RTL8187B Larry Finger
2008-07-19  0:42 ` Herton Ronaldo Krzesinski [this message]
2008-07-19  4:14   ` Larry Finger
2008-07-20  0:39     ` Hin-Tak Leung
2008-07-20  2:55       ` Larry Finger
2008-07-22 19:13         ` Herton Ronaldo Krzesinski
2008-07-22 22:25           ` Hin-Tak Leung
2008-07-22 22:40             ` Herton Ronaldo Krzesinski
2008-07-23  3:49               ` Larry Finger
2008-07-23  5:43                 ` Commit 741b4fbc44 (mac80211: fix TX sequence numbers) breaks rtl8187 Larry Finger
2008-07-23 12:55                   ` Stefanik Gábor
2008-07-24 14:22                     ` Johannes Berg
2008-07-23 14:55                   ` Johannes Berg
2008-07-23 15:32                     ` Larry Finger
2008-07-23 16:27                       ` Johannes Berg
2008-07-23 18:03                         ` Larry Finger
2008-07-23 19:03                           ` Johannes Berg
2008-07-24  3:28                       ` Hin-Tak Leung
2008-07-24  5:40                         ` Larry Finger
2008-07-24  8:05                           ` Hin-Tak Leung
2008-07-24 11:34                             ` Johannes Berg
2008-07-25  3:42                             ` Hin-Tak Leung
2008-07-24 16:37                           ` Herton Ronaldo Krzesinski
2008-07-25  1:28                             ` Hin-Tak Leung
2008-07-29  2:39                       ` Hin-Tak Leung
2008-07-29  3:15                         ` Larry Finger
2008-07-29  3:29                           ` Herton Ronaldo Krzesinski
2008-07-29  3:40                             ` Larry Finger
2008-07-29  3:21                         ` Herton Ronaldo Krzesinski
2008-07-29  6:53                           ` Johannes Berg
2008-07-29  8:23                             ` Tomas Winkler
2008-07-29  8:28                               ` Johannes Berg
2008-07-29  8:38                                 ` Tomas Winkler
2008-07-29  9:16                                   ` Johannes Berg
2008-07-29  9:26                                     ` Tomas Winkler
2008-07-29  9:29                                       ` Johannes Berg
2008-07-29 11:16                                         ` Tomas Winkler
2008-07-29 11:18                                           ` Johannes Berg
2008-07-29 21:44                                             ` Kalle Valo
2008-07-29 21:40                                     ` Kalle Valo
2008-07-29 21:26                                 ` Kalle Valo
2008-07-29 21:19                               ` Kalle Valo
2008-07-30  1:01                                 ` Hin-Tak Leung
2008-07-29 21:17                             ` Kalle Valo
2008-07-29 21:12                           ` Kalle Valo
2008-07-30  3:37                             ` Herton Ronaldo Krzesinski
2008-07-30  8:54                               ` Kalle Valo
2008-07-30  9:52                                 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807182142.59921.herton@mandriva.com.br \
    --to=herton@mandriva.com.br \
    --cc=Larry.Finger@lwfinger.net \
    --cc=hintak.leung@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).