linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
	Ron Rindjunsky <ron.rindjunsky@intel.com>
Subject: [RFC 0/3] mac80211 tx mq aggregation fixes
Date: Sat, 19 Jul 2008 02:41:47 +0200	[thread overview]
Message-ID: <20080719004147.795661000@sipsolutions.net> (raw)

As we discussed earlier, there is now a race in mac80211 where 
you can get packets queued onto the aggregation queue while draining
it, and some can be left on there. Fixing that is achieved by deferring
the draining to a workqueue and calling synchronize_net() before doing   
it.

Also noticed another problem: when we start aggregation we add the
queue before the hardware said it's ok, thus we can end up queuing    
packets to a new aggregation queue we won't be using, fix that one    
before since it was easier.        

Locking gets a bit tricky unfortunately.

johannes


             reply	other threads:[~2008-07-19  0:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-19  0:41 Johannes Berg [this message]
2008-07-19  0:41 ` [RFC 1/3] mac80211: sane arguments to ieee80211_ht_agg_queue_remove Johannes Berg
2008-07-19  0:41 ` [RFC 2/3] mac80211: fix race during adding HT queues Johannes Berg
2008-07-19  0:41 ` [RFC 3/3] mac80211: fix requeue race Johannes Berg
2008-07-19  0:52   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080719004147.795661000@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ron.rindjunsky@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).