* [RFC 1/3] mac80211: sane arguments to ieee80211_ht_agg_queue_remove
2008-07-19 0:41 [RFC 0/3] mac80211 tx mq aggregation fixes Johannes Berg
@ 2008-07-19 0:41 ` Johannes Berg
2008-07-19 0:41 ` [RFC 2/3] mac80211: fix race during adding HT queues Johannes Berg
2008-07-19 0:41 ` [RFC 3/3] mac80211: fix requeue race Johannes Berg
2 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2008-07-19 0:41 UTC (permalink / raw)
To: linux-wireless; +Cc: David Miller, Ron Rindjunsky
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/main.c | 8 +++++---
net/mac80211/wme.c | 7 +------
net/mac80211/wme.h | 3 +--
3 files changed, 7 insertions(+), 11 deletions(-)
--- everything.orig/net/mac80211/main.c 2008-07-18 23:52:25.000000000 +0200
+++ everything/net/mac80211/main.c 2008-07-19 00:14:30.000000000 +0200
@@ -644,7 +644,8 @@ int ieee80211_start_tx_ba_session(struct
/* No need to requeue the packets in the agg queue, since we
* held the tx lock: no packet could be enqueued to the newly
* allocated queue */
- ieee80211_ht_agg_queue_remove(local, sta, tid, 0);
+ ieee80211_ht_agg_queue_remove(local, sta->tid_to_tx_q[tid], false);
+ sta->tid_to_tx_q[tid] = ieee80211_num_queues(hw);
#ifdef CONFIG_MAC80211_HT_DEBUG
printk(KERN_DEBUG "BA request denied - HW unavailable for"
" tid %d\n", tid);
@@ -740,7 +741,7 @@ int ieee80211_stop_tx_ba_session(struct
goto stop_BA_exit;
}
-stop_BA_exit:
+ stop_BA_exit:
spin_unlock_bh(&sta->lock);
rcu_read_unlock();
return ret;
@@ -852,7 +853,8 @@ void ieee80211_stop_tx_ba_cb(struct ieee
agg_queue = sta->tid_to_tx_q[tid];
- ieee80211_ht_agg_queue_remove(local, sta, tid, 1);
+ ieee80211_ht_agg_queue_remove(local, agg_queue, true);
+ sta->tid_to_tx_q[tid] = ieee80211_num_queues(hw);
/* We just requeued the all the frames that were in the
* removed queue, and since we might miss a softirq we do
--- everything.orig/net/mac80211/wme.c 2008-07-19 00:07:24.000000000 +0200
+++ everything/net/mac80211/wme.c 2008-07-19 00:14:57.000000000 +0200
@@ -223,15 +223,10 @@ int ieee80211_ht_agg_queue_add(struct ie
* the caller needs to hold netdev_get_tx_queue(local->mdev, X)->lock
*/
void ieee80211_ht_agg_queue_remove(struct ieee80211_local *local,
- struct sta_info *sta, u16 tid,
- u8 requeue)
+ u16 agg_queue, bool requeue)
{
- int agg_queue = sta->tid_to_tx_q[tid];
- struct ieee80211_hw *hw = &local->hw;
-
/* return the qdisc to the pool */
clear_bit(agg_queue, local->queue_pool);
- sta->tid_to_tx_q[tid] = ieee80211_num_queues(hw);
if (requeue) {
ieee80211_requeue(local, agg_queue);
--- everything.orig/net/mac80211/wme.h 2008-07-19 00:08:04.000000000 +0200
+++ everything/net/mac80211/wme.h 2008-07-19 00:08:28.000000000 +0200
@@ -27,8 +27,7 @@ u16 ieee80211_select_queue(struct net_de
int ieee80211_ht_agg_queue_add(struct ieee80211_local *local,
struct sta_info *sta, u16 tid);
void ieee80211_ht_agg_queue_remove(struct ieee80211_local *local,
- struct sta_info *sta, u16 tid,
- u8 requeue);
+ u16 agg_queue, bool requeue);
void ieee80211_requeue(struct ieee80211_local *local, int queue);
#endif /* _WME_H */
--
^ permalink raw reply [flat|nested] 5+ messages in thread* [RFC 2/3] mac80211: fix race during adding HT queues
2008-07-19 0:41 [RFC 0/3] mac80211 tx mq aggregation fixes Johannes Berg
2008-07-19 0:41 ` [RFC 1/3] mac80211: sane arguments to ieee80211_ht_agg_queue_remove Johannes Berg
@ 2008-07-19 0:41 ` Johannes Berg
2008-07-19 0:41 ` [RFC 3/3] mac80211: fix requeue race Johannes Berg
2 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2008-07-19 0:41 UTC (permalink / raw)
To: linux-wireless; +Cc: David Miller, Ron Rindjunsky
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/ieee80211_i.h | 6 ++++++
net/mac80211/main.c | 21 ++++++++++++---------
net/mac80211/wme.c | 13 ++++++++-----
3 files changed, 26 insertions(+), 14 deletions(-)
--- everything.orig/net/mac80211/main.c 2008-07-19 00:19:28.000000000 +0200
+++ everything/net/mac80211/main.c 2008-07-19 00:27:35.000000000 +0200
@@ -558,7 +558,7 @@ int ieee80211_start_tx_ba_session(struct
struct ieee80211_sub_if_data *sdata;
u16 start_seq_num = 0;
u8 *state;
- int ret;
+ int ret = 0, reserved_queue;
DECLARE_MAC_BUF(mac);
if (tid >= STA_TID_NUM)
@@ -619,16 +619,16 @@ int ieee80211_start_tx_ba_session(struct
init_timer(&sta->ampdu_mlme.tid_tx[tid]->addba_resp_timer);
/* create a new queue for this aggregation */
- ret = ieee80211_ht_agg_queue_add(local, sta, tid);
+ reserved_queue = ieee80211_ht_agg_queue_add(local, sta, tid);
/* case no queue is available to aggregation
* don't switch to aggregation */
- if (ret) {
+ if (reserved_queue < 0) {
#ifdef CONFIG_MAC80211_HT_DEBUG
printk(KERN_DEBUG "BA request denied - queue unavailable for"
" tid %d\n", tid);
#endif /* CONFIG_MAC80211_HT_DEBUG */
- goto err_unlock_queue;
+ goto err_free_state;
}
sdata = sta->sdata;
@@ -642,8 +642,8 @@ int ieee80211_start_tx_ba_session(struct
if (ret) {
/* No need to requeue the packets in the agg queue, since we
- * held the tx lock: no packet could be enqueued to the newly
- * allocated queue */
+ * haven't yet marked the queue in the queue_pool no packet
+ * can have been enqueued to the newly allocated queue */
ieee80211_ht_agg_queue_remove(local, sta->tid_to_tx_q[tid], false);
sta->tid_to_tx_q[tid] = ieee80211_num_queues(hw);
#ifdef CONFIG_MAC80211_HT_DEBUG
@@ -651,10 +651,13 @@ int ieee80211_start_tx_ba_session(struct
" tid %d\n", tid);
#endif /* CONFIG_MAC80211_HT_DEBUG */
*state = HT_AGG_STATE_IDLE;
- goto err_unlock_queue;
+ goto err_free_state;
}
- /* Will put all the packets in the new SW queue */
+ /* mark the queue as used now */
+ set_bit(reserved_queue, local->queue_pool);
+
+ /* Put all the packets onto the new aggregation queue */
ieee80211_requeue(local, ieee802_1d_to_ac[tid]);
spin_unlock_bh(&sta->lock);
@@ -678,7 +681,7 @@ int ieee80211_start_tx_ba_session(struct
#endif
goto exit;
-err_unlock_queue:
+err_free_state:
kfree(sta->ampdu_mlme.tid_tx[tid]);
sta->ampdu_mlme.tid_tx[tid] = NULL;
ret = -EBUSY;
--- everything.orig/net/mac80211/wme.c 2008-07-19 00:16:51.000000000 +0200
+++ everything/net/mac80211/wme.c 2008-07-19 00:34:29.000000000 +0200
@@ -183,6 +183,10 @@ u16 ieee80211_select_queue(struct net_de
return queue;
}
+/*
+ * Must be called under local->sta_lock, will return a negative
+ * error code or the number of the reserved queue.
+ */
int ieee80211_ht_agg_queue_add(struct ieee80211_local *local,
struct sta_info *sta, u16 tid)
{
@@ -196,7 +200,7 @@ int ieee80211_ht_agg_queue_add(struct ie
/* try to get a Qdisc from the pool */
for (i = local->hw.queues; i < ieee80211_num_queues(&local->hw); i++)
- if (!test_and_set_bit(i, local->queue_pool)) {
+ if (!test_bit(i, local->queue_pool)) {
ieee80211_stop_queue(local_to_hw(local), i);
sta->tid_to_tx_q[tid] = i;
@@ -208,12 +212,11 @@ int ieee80211_ht_agg_queue_add(struct ie
if (net_ratelimit()) {
DECLARE_MAC_BUF(mac);
printk(KERN_DEBUG "allocated aggregation queue"
- " %d tid %d addr %s pool=0x%lX\n",
- i, tid, print_mac(mac, sta->addr),
- local->queue_pool[0]);
+ " %d tid %d addr %s\n",
+ i, tid, print_mac(mac, sta->addr));
}
#endif /* CONFIG_MAC80211_HT_DEBUG */
- return 0;
+ return i;
}
return -EAGAIN;
--- everything.orig/net/mac80211/ieee80211_i.h 2008-07-19 00:28:06.000000000 +0200
+++ everything/net/mac80211/ieee80211_i.h 2008-07-19 00:30:31.000000000 +0200
@@ -549,6 +549,12 @@ struct ieee80211_local {
const struct ieee80211_ops *ops;
+ /*
+ * Pool of reserved ampdu queues. Note that setting a bit
+ * here to reserve the queue must only be done under sta_lock
+ * to protect the setting process, we can unfortunately not
+ * do it with atomic operations at this time.
+ */
unsigned long queue_pool[BITS_TO_LONGS(QD_MAX_QUEUES)];
struct net_device *mdev; /* wmaster# - "master" 802.11 device */
--
^ permalink raw reply [flat|nested] 5+ messages in thread* [RFC 3/3] mac80211: fix requeue race
2008-07-19 0:41 [RFC 0/3] mac80211 tx mq aggregation fixes Johannes Berg
2008-07-19 0:41 ` [RFC 1/3] mac80211: sane arguments to ieee80211_ht_agg_queue_remove Johannes Berg
2008-07-19 0:41 ` [RFC 2/3] mac80211: fix race during adding HT queues Johannes Berg
@ 2008-07-19 0:41 ` Johannes Berg
2008-07-19 0:52 ` Johannes Berg
2 siblings, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2008-07-19 0:41 UTC (permalink / raw)
To: linux-wireless; +Cc: David Miller, Ron Rindjunsky
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/iwlwifi/iwl-tx.c | 4
include/net/mac80211.h | 16 ---
net/mac80211/ieee80211_i.h | 7 +
net/mac80211/main.c | 146 +++++++++++++++++++++-------------
net/mac80211/wme.c | 76 ++++++++++++++++-
net/mac80211/wme.h | 4
6 files changed, 175 insertions(+), 78 deletions(-)
--- everything.orig/net/mac80211/ieee80211_i.h 2008-07-19 01:37:10.000000000 +0200
+++ everything/net/mac80211/ieee80211_i.h 2008-07-19 02:04:39.000000000 +0200
@@ -534,8 +534,7 @@ struct ieee80211_sub_if_data *vif_to_sda
enum {
IEEE80211_RX_MSG = 1,
IEEE80211_TX_STATUS_MSG = 2,
- IEEE80211_DELBA_MSG = 3,
- IEEE80211_ADDBA_MSG = 4,
+ IEEE80211_ADDBA_MSG = 3,
};
/* maximum number of hardware queues we support. */
@@ -557,6 +556,10 @@ struct ieee80211_local {
*/
unsigned long queue_pool[BITS_TO_LONGS(QD_MAX_QUEUES)];
+ struct work_struct tx_ba_stop_work;
+ spinlock_t tx_ba_stop_lock;
+ struct list_head tx_ba_stop_list;
+
struct net_device *mdev; /* wmaster# - "master" 802.11 device */
int open_count;
int monitors, cooked_mntrs;
--- everything.orig/net/mac80211/main.c 2008-07-19 01:38:52.000000000 +0200
+++ everything/net/mac80211/main.c 2008-07-19 02:28:00.000000000 +0200
@@ -644,7 +644,7 @@ int ieee80211_start_tx_ba_session(struct
/* No need to requeue the packets in the agg queue, since we
* haven't yet marked the queue in the queue_pool no packet
* can have been enqueued to the newly allocated queue */
- ieee80211_ht_agg_queue_remove(local, sta->tid_to_tx_q[tid], false);
+ ieee80211_ht_agg_queue_remove(local, sta->tid_to_tx_q[tid], -1);
sta->tid_to_tx_q[tid] = ieee80211_num_queues(hw);
#ifdef CONFIG_MAC80211_HT_DEBUG
printk(KERN_DEBUG "BA request denied - HW unavailable for"
@@ -658,7 +658,7 @@ int ieee80211_start_tx_ba_session(struct
set_bit(reserved_queue, local->queue_pool);
/* Put all the packets onto the new aggregation queue */
- ieee80211_requeue(local, ieee802_1d_to_ac[tid]);
+ ieee80211_requeue_toagg(local, ieee802_1d_to_ac[tid]);
spin_unlock_bh(&sta->lock);
/* send an addBA request */
@@ -805,9 +805,39 @@ void ieee80211_start_tx_ba_cb(struct iee
}
EXPORT_SYMBOL(ieee80211_start_tx_ba_cb);
-void ieee80211_stop_tx_ba_cb(struct ieee80211_hw *hw, u8 *ra, u8 tid)
+void ieee80211_start_tx_ba_cb_irqsafe(struct ieee80211_hw *hw,
+ const u8 *ra, u16 tid)
{
struct ieee80211_local *local = hw_to_local(hw);
+ struct ieee80211_ra_tid *ra_tid;
+ struct sk_buff *skb = dev_alloc_skb(0);
+
+ if (unlikely(!skb)) {
+#ifdef CONFIG_MAC80211_HT_DEBUG
+ if (net_ratelimit())
+ printk(KERN_WARNING "%s: Not enough memory, "
+ "dropping start BA session", skb->dev->name);
+#endif
+ return;
+ }
+ ra_tid = (struct ieee80211_ra_tid *) &skb->cb;
+ memcpy(&ra_tid->ra, ra, ETH_ALEN);
+ ra_tid->tid = tid;
+
+ skb->pkt_type = IEEE80211_ADDBA_MSG;
+ skb_queue_tail(&local->skb_queue, skb);
+ tasklet_schedule(&local->tasklet);
+}
+EXPORT_SYMBOL(ieee80211_start_tx_ba_cb_irqsafe);
+
+struct tx_ba_work {
+ struct list_head list;
+ u8 ra[ETH_ALEN];
+ u8 tid;
+};
+
+static void ieee80211_stop_tx_ba_do(struct ieee80211_local *local, u8 *ra, u8 tid)
+{
struct sta_info *sta;
u8 *state;
int agg_queue;
@@ -856,15 +886,13 @@ void ieee80211_stop_tx_ba_cb(struct ieee
agg_queue = sta->tid_to_tx_q[tid];
- ieee80211_ht_agg_queue_remove(local, agg_queue, true);
- sta->tid_to_tx_q[tid] = ieee80211_num_queues(hw);
-
- /* We just requeued the all the frames that were in the
- * removed queue, and since we might miss a softirq we do
- * netif_schedule_queue. ieee80211_wake_queue is not used
- * here as this queue is not necessarily stopped
+ /*
+ * From this point on, the queue will no longer be used to
+ * queue frames on.
*/
- netif_schedule_queue(netdev_get_tx_queue(local->mdev, agg_queue));
+ sta->tid_to_tx_q[tid] = ieee80211_num_queues(&local->hw);
+
+ /* Therefore, we can free the state now. */
spin_lock_bh(&sta->lock);
*state = HT_AGG_STATE_IDLE;
sta->ampdu_mlme.addba_req_num[tid] = 0;
@@ -873,58 +901,72 @@ void ieee80211_stop_tx_ba_cb(struct ieee
spin_unlock_bh(&sta->lock);
rcu_read_unlock();
+
+ /*
+ * Now we need to synchronise so that the select_queue function
+ * can no longer queue on the aggregation queue.
+ */
+ synchronize_net();
+
+ /* Then, we can kill that queue. */
+ ieee80211_ht_agg_queue_remove(local, agg_queue, ieee802_1d_to_ac[tid]);
+
+ /*
+ * We just requeued the all the frames that were in the
+ * removed queue, and since we might miss a softirq we do
+ * netif_schedule_queue. ieee80211_wake_queue is not used
+ * here as this queue is not necessarily stopped
+ */
+ netif_schedule_queue(netdev_get_tx_queue(local->mdev, agg_queue));
}
-EXPORT_SYMBOL(ieee80211_stop_tx_ba_cb);
-void ieee80211_start_tx_ba_cb_irqsafe(struct ieee80211_hw *hw,
- const u8 *ra, u16 tid)
+static void ieee80211_stop_tx_ba_work(struct work_struct *work)
{
- struct ieee80211_local *local = hw_to_local(hw);
- struct ieee80211_ra_tid *ra_tid;
- struct sk_buff *skb = dev_alloc_skb(0);
+ struct ieee80211_local *local;
+ struct tx_ba_work *todo;
+ unsigned long flags;
- if (unlikely(!skb)) {
-#ifdef CONFIG_MAC80211_HT_DEBUG
- if (net_ratelimit())
- printk(KERN_WARNING "%s: Not enough memory, "
- "dropping start BA session", skb->dev->name);
-#endif
- return;
- }
- ra_tid = (struct ieee80211_ra_tid *) &skb->cb;
- memcpy(&ra_tid->ra, ra, ETH_ALEN);
- ra_tid->tid = tid;
+ local = container_of(work, struct ieee80211_local, tx_ba_stop_work);
- skb->pkt_type = IEEE80211_ADDBA_MSG;
- skb_queue_tail(&local->skb_queue, skb);
- tasklet_schedule(&local->tasklet);
+ spin_lock_irqsave(&local->tx_ba_stop_lock, flags);
+ while (1) {
+ if (list_empty(&local->tx_ba_stop_list))
+ break;
+ todo = list_first_entry(&local->tx_ba_stop_list,
+ struct tx_ba_work, list);
+ list_del(&todo->list);
+ spin_unlock_irqrestore(&local->tx_ba_stop_lock, flags);
+
+ ieee80211_stop_tx_ba_do(local, todo->ra, todo->tid);
+ kfree(todo);
+
+ spin_lock_irqsave(&local->tx_ba_stop_lock, flags);
+ }
+ spin_unlock_irqrestore(&local->tx_ba_stop_lock, flags);
}
-EXPORT_SYMBOL(ieee80211_start_tx_ba_cb_irqsafe);
-void ieee80211_stop_tx_ba_cb_irqsafe(struct ieee80211_hw *hw,
- const u8 *ra, u16 tid)
+void ieee80211_stop_tx_ba_cb(struct ieee80211_hw *hw, const u8 *ra, u8 tid)
{
struct ieee80211_local *local = hw_to_local(hw);
- struct ieee80211_ra_tid *ra_tid;
- struct sk_buff *skb = dev_alloc_skb(0);
+ struct tx_ba_work *todo = kzalloc(sizeof(*todo), GFP_ATOMIC);
+ unsigned long flags;
- if (unlikely(!skb)) {
+ if (unlikely(!todo)) {
#ifdef CONFIG_MAC80211_HT_DEBUG
- if (net_ratelimit())
- printk(KERN_WARNING "%s: Not enough memory, "
- "dropping stop BA session", skb->dev->name);
+ printk(KERN_WARNING "%s: Not enough memory, "
+ "dropping stop BA session", wiphy_name(local->hw.wiphy));
#endif
return;
}
- ra_tid = (struct ieee80211_ra_tid *) &skb->cb;
- memcpy(&ra_tid->ra, ra, ETH_ALEN);
- ra_tid->tid = tid;
+ memcpy(todo->ra, ra, ETH_ALEN);
+ todo->tid = tid;
- skb->pkt_type = IEEE80211_DELBA_MSG;
- skb_queue_tail(&local->skb_queue, skb);
- tasklet_schedule(&local->tasklet);
+ spin_lock_irqsave(&local->tx_ba_stop_lock, flags);
+ list_add_tail(&todo->list, &local->tx_ba_stop_list);
+ queue_work(local->hw.workqueue, &local->tx_ba_stop_work);
+ spin_unlock_irqrestore(&local->tx_ba_stop_lock, flags);
}
-EXPORT_SYMBOL(ieee80211_stop_tx_ba_cb_irqsafe);
+EXPORT_SYMBOL(ieee80211_stop_tx_ba_cb);
static void ieee80211_set_multicast_list(struct net_device *dev)
{
@@ -1215,12 +1257,6 @@ static void ieee80211_tasklet_handler(un
skb->pkt_type = 0;
ieee80211_tx_status(local_to_hw(local), skb);
break;
- case IEEE80211_DELBA_MSG:
- ra_tid = (struct ieee80211_ra_tid *) &skb->cb;
- ieee80211_stop_tx_ba_cb(local_to_hw(local),
- ra_tid->ra, ra_tid->tid);
- dev_kfree_skb(skb);
- break;
case IEEE80211_ADDBA_MSG:
ra_tid = (struct ieee80211_ra_tid *) &skb->cb;
ieee80211_start_tx_ba_cb(local_to_hw(local),
@@ -1599,6 +1635,10 @@ struct ieee80211_hw *ieee80211_alloc_hw(
INIT_DELAYED_WORK(&local->scan_work, ieee80211_sta_scan_work);
+ INIT_LIST_HEAD(&local->tx_ba_stop_list);
+ spin_lock_init(&local->tx_ba_stop_lock);
+ INIT_WORK(&local->tx_ba_stop_work, ieee80211_stop_tx_ba_work);
+
sta_info_init(local);
tasklet_init(&local->tx_pending_tasklet, ieee80211_tx_pending,
--- everything.orig/include/net/mac80211.h 2008-07-19 02:03:18.000000000 +0200
+++ everything/include/net/mac80211.h 2008-07-19 02:07:08.000000000 +0200
@@ -1734,21 +1734,9 @@ int ieee80211_stop_tx_ba_session(struct
*
* This function must be called by low level driver once it has
* finished with preparations for the BA session tear down.
+ * This function can be called in any context.
*/
-void ieee80211_stop_tx_ba_cb(struct ieee80211_hw *hw, u8 *ra, u8 tid);
-
-/**
- * ieee80211_stop_tx_ba_cb_irqsafe - low level driver ready to stop aggregate.
- * @hw: pointer as obtained from ieee80211_alloc_hw().
- * @ra: receiver address of the BA session recipient.
- * @tid: the desired TID to BA on.
- *
- * This function must be called by low level driver once it has
- * finished with preparations for the BA session tear down.
- * This version of the function is IRQ-safe.
- */
-void ieee80211_stop_tx_ba_cb_irqsafe(struct ieee80211_hw *hw, const u8 *ra,
- u16 tid);
+void ieee80211_stop_tx_ba_cb(struct ieee80211_hw *hw, const u8 *ra, u8 tid);
/**
* ieee80211_notify_mac - low level driver notification
--- everything.orig/drivers/net/wireless/iwlwifi/iwl-tx.c 2008-07-19 02:10:42.000000000 +0200
+++ everything/drivers/net/wireless/iwlwifi/iwl-tx.c 2008-07-19 02:10:46.000000000 +0200
@@ -1304,7 +1304,7 @@ int iwl_tx_agg_stop(struct iwl_priv *pri
if (ret)
return ret;
- ieee80211_stop_tx_ba_cb_irqsafe(priv->hw, ra, tid);
+ ieee80211_stop_tx_ba_cb(priv->hw, ra, tid);
return 0;
}
@@ -1328,7 +1328,7 @@ int iwl_txq_check_empty(struct iwl_priv
priv->cfg->ops->lib->txq_agg_disable(priv, txq_id,
ssn, tx_fifo);
tid_data->agg.state = IWL_AGG_OFF;
- ieee80211_stop_tx_ba_cb_irqsafe(priv->hw, addr, tid);
+ ieee80211_stop_tx_ba_cb(priv->hw, addr, tid);
}
break;
case IWL_EMPTYING_HW_QUEUE_ADDBA:
--- everything.orig/net/mac80211/wme.c 2008-07-19 02:14:14.000000000 +0200
+++ everything/net/mac80211/wme.c 2008-07-19 02:36:01.000000000 +0200
@@ -222,17 +222,83 @@ int ieee80211_ht_agg_queue_add(struct ie
return -EAGAIN;
}
+static void ieee80211_requeue_fromagg(struct ieee80211_local *local,
+ int queue, u16 new_queue)
+{
+ struct netdev_queue *from_txq = netdev_get_tx_queue(local->mdev, queue);
+ struct netdev_queue *to_txq;
+ struct sk_buff_head list;
+ spinlock_t *from_root_lock = NULL, *to_root_lock;
+ struct Qdisc *qdisc, *to_qdisc = NULL;
+ u32 len;
+
+ rcu_read_lock_bh();
+
+ qdisc = rcu_dereference(from_txq->qdisc);
+ if (!qdisc || !qdisc->dequeue)
+ goto out_unlock;
+
+ to_txq = netdev_get_tx_queue(local->mdev, new_queue);
+ to_qdisc = rcu_dereference(to_txq->qdisc);
+ if (!to_qdisc || !to_qdisc->enqueue)
+ goto out_unlock;
+
+ to_root_lock = qdisc_root_lock(to_qdisc);
+
+ if (to_qdisc != qdisc)
+ from_root_lock = qdisc_root_lock(qdisc);
+
+ skb_queue_head_init(&list);
+
+ spin_lock(to_root_lock);
+
+ if (from_root_lock) {
+ spin_lock(from_root_lock);
+ for (len = qdisc->q.qlen; len > 0; len--) {
+ struct sk_buff *skb = qdisc->dequeue(qdisc);
+
+ if (skb)
+ __skb_queue_tail(&list, skb);
+ }
+ spin_unlock(from_root_lock);
+ } else {
+ for (len = qdisc->q.qlen; len > 0; len--) {
+ struct sk_buff *skb = qdisc->dequeue(qdisc);
+
+ if (skb)
+ __skb_queue_tail(&list, skb);
+ }
+ }
+
+ for (len = list.qlen; len > 0; len--) {
+ struct sk_buff *skb = __skb_dequeue(&list);
+
+ BUG_ON(!skb);
+ skb_set_queue_mapping(skb, new_queue);
+
+ to_qdisc->enqueue(skb, qdisc);
+ }
+
+ spin_unlock(to_root_lock);
+
+ out_unlock:
+ rcu_read_unlock_bh();
+}
+
/**
* the caller needs to hold netdev_get_tx_queue(local->mdev, X)->lock
+ *
+ * regular_queue >= 0 indicates that requeueing must be done and will
+ * go to that queue.
*/
void ieee80211_ht_agg_queue_remove(struct ieee80211_local *local,
- u16 agg_queue, bool requeue)
+ u16 agg_queue, int regular_queue)
{
/* return the qdisc to the pool */
clear_bit(agg_queue, local->queue_pool);
- if (requeue) {
- ieee80211_requeue(local, agg_queue);
+ if (regular_queue >= 0) {
+ ieee80211_requeue_fromagg(local, agg_queue, regular_queue);
} else {
struct netdev_queue *txq;
spinlock_t *root_lock;
@@ -246,7 +312,7 @@ void ieee80211_ht_agg_queue_remove(struc
}
}
-void ieee80211_requeue(struct ieee80211_local *local, int queue)
+void ieee80211_requeue_toagg(struct ieee80211_local *local, int queue)
{
struct netdev_queue *txq = netdev_get_tx_queue(local->mdev, queue);
struct sk_buff_head list;
@@ -291,6 +357,6 @@ void ieee80211_requeue(struct ieee80211_
spin_unlock(root_lock);
}
-out_unlock:
+ out_unlock:
rcu_read_unlock_bh();
}
--- everything.orig/net/mac80211/wme.h 2008-07-19 02:14:37.000000000 +0200
+++ everything/net/mac80211/wme.h 2008-07-19 02:28:12.000000000 +0200
@@ -27,7 +27,7 @@ u16 ieee80211_select_queue(struct net_de
int ieee80211_ht_agg_queue_add(struct ieee80211_local *local,
struct sta_info *sta, u16 tid);
void ieee80211_ht_agg_queue_remove(struct ieee80211_local *local,
- u16 agg_queue, bool requeue);
-void ieee80211_requeue(struct ieee80211_local *local, int queue);
+ u16 agg_queue, int regular_queue);
+void ieee80211_requeue_toagg(struct ieee80211_local *local, int from);
#endif /* _WME_H */
--
^ permalink raw reply [flat|nested] 5+ messages in thread