Re: [PATCH 3/4] rfkill: document the rfkill struct locking

[Ivo van Doorn <ivdoorn@gmail.com>]

On Tuesday 15 July 2008, Henrique de Moraes Holschuh wrote:
> Reorder fields in struct rfkill and add comments to make it clear
> which fields are protected by rfkill->mutex.
> 
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: Ivo van Doorn <IvDoorn@gmail.com>
> ---
>  include/linux/rfkill.h |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index c5f6e54..630b573 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -89,13 +89,14 @@ struct rfkill {
>  	const char *name;
>  	enum rfkill_type type;
>  
> -	enum rfkill_state state;
> +	void *data;
>  	bool user_claim_unsupported;
>  	bool user_claim;
>  
> +	/* the mutex serializes callbacks and also protects
> +	 * the state */

Please move/copy the comment into the kerneldoc above the
structure declaration as well.

>  	struct mutex mutex;
> -
> -	void *data;

Not a real problem, but the data pointer doesn't need to be moved,
since it is only used for the callback functions. So technically it is
under the protection of the mutex as well.

> +	enum rfkill_state state;
>  	int (*toggle_radio)(void *data, enum rfkill_state state);
>  	int (*get_state)(void *data, enum rfkill_state *state);

Ivo