* [PATCH 12/12] ath5k: Fix a compilation error after reg list update
@ 2008-07-20 3:52 Nick Kossifidis
2008-07-22 14:36 ` Jiri Slaby
2008-07-22 14:53 ` Jiri Slaby
0 siblings, 2 replies; 6+ messages in thread
From: Nick Kossifidis @ 2008-07-20 3:52 UTC (permalink / raw)
To: ath5k-devel, linux-wireless; +Cc: linville, jirislaby, mcgrof
Last minute fix...
AR5K_CPCORN is changed to AR5K_CPCOVF in reg list update so we have to update debug.c in order to compile
Changes-licensed-under: ISC
Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
---
diff --git a/drivers/net/wireless/ath5k/debug.c b/drivers/net/wireless/ath5k/debug.c
index 41d5fa3..6fa6c8e 100644
--- a/drivers/net/wireless/ath5k/debug.c
+++ b/drivers/net/wireless/ath5k/debug.c
@@ -129,7 +129,7 @@ static struct reg regs[] = {
REG_STRUCT_INIT(AR5K_CPC1),
REG_STRUCT_INIT(AR5K_CPC2),
REG_STRUCT_INIT(AR5K_CPC3),
- REG_STRUCT_INIT(AR5K_CPCORN),
+ REG_STRUCT_INIT(AR5K_CPCOVF),
REG_STRUCT_INIT(AR5K_RESET_CTL),
REG_STRUCT_INIT(AR5K_SLEEP_CTL),
REG_STRUCT_INIT(AR5K_INTPEND),
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 12/12] ath5k: Fix a compilation error after reg list update
2008-07-20 3:52 [PATCH 12/12] ath5k: Fix a compilation error after reg list update Nick Kossifidis
@ 2008-07-22 14:36 ` Jiri Slaby
2008-07-28 13:04 ` [ath5k-devel] " Nick Kossifidis
2008-07-22 14:53 ` Jiri Slaby
1 sibling, 1 reply; 6+ messages in thread
From: Jiri Slaby @ 2008-07-22 14:36 UTC (permalink / raw)
To: ath5k-devel, linux-wireless, linville, jirislaby, mcgrof
On 07/20/2008 05:52 AM, Nick Kossifidis wrote:
> Last minute fix...
>
> AR5K_CPCORN is changed to AR5K_CPCOVF in reg list update so we have to update debug.c in order to compile
>
> Changes-licensed-under: ISC
> Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
>
> ---
> diff --git a/drivers/net/wireless/ath5k/debug.c b/drivers/net/wireless/ath5k/debug.c
> index 41d5fa3..6fa6c8e 100644
> --- a/drivers/net/wireless/ath5k/debug.c
> +++ b/drivers/net/wireless/ath5k/debug.c
> @@ -129,7 +129,7 @@ static struct reg regs[] = {
> REG_STRUCT_INIT(AR5K_CPC1),
> REG_STRUCT_INIT(AR5K_CPC2),
> REG_STRUCT_INIT(AR5K_CPC3),
> - REG_STRUCT_INIT(AR5K_CPCORN),
> + REG_STRUCT_INIT(AR5K_CPCOVF),
> REG_STRUCT_INIT(AR5K_RESET_CTL),
> REG_STRUCT_INIT(AR5K_SLEEP_CTL),
> REG_STRUCT_INIT(AR5K_INTPEND),
Please amend this to the patch 1 to not break bisectability.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 12/12] ath5k: Fix a compilation error after reg list update
2008-07-20 3:52 [PATCH 12/12] ath5k: Fix a compilation error after reg list update Nick Kossifidis
2008-07-22 14:36 ` Jiri Slaby
@ 2008-07-22 14:53 ` Jiri Slaby
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Slaby @ 2008-07-22 14:53 UTC (permalink / raw)
To: ath5k-devel, linux-wireless, linville, jirislaby, mcgrof,
Nick Kossifidis
Why the hell the mailer cropped Nick's address away...
On 07/20/2008 05:52 AM, Nick Kossifidis wrote:
> Last minute fix...
>
> AR5K_CPCORN is changed to AR5K_CPCOVF in reg list update so we have to update debug.c in order to compile
>
> Changes-licensed-under: ISC
> Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
>
> ---
> diff --git a/drivers/net/wireless/ath5k/debug.c b/drivers/net/wireless/ath5k/debug.c
> index 41d5fa3..6fa6c8e 100644
> --- a/drivers/net/wireless/ath5k/debug.c
> +++ b/drivers/net/wireless/ath5k/debug.c
> @@ -129,7 +129,7 @@ static struct reg regs[] = {
> REG_STRUCT_INIT(AR5K_CPC1),
> REG_STRUCT_INIT(AR5K_CPC2),
> REG_STRUCT_INIT(AR5K_CPC3),
> - REG_STRUCT_INIT(AR5K_CPCORN),
> + REG_STRUCT_INIT(AR5K_CPCOVF),
> REG_STRUCT_INIT(AR5K_RESET_CTL),
> REG_STRUCT_INIT(AR5K_SLEEP_CTL),
> REG_STRUCT_INIT(AR5K_INTPEND),
Please amend this to the patch 1 to not break bisectability.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ath5k-devel] [PATCH 12/12] ath5k: Fix a compilation error after reg list update
2008-07-22 14:36 ` Jiri Slaby
@ 2008-07-28 13:04 ` Nick Kossifidis
2008-07-28 13:10 ` Pavel Roskin
0 siblings, 1 reply; 6+ messages in thread
From: Nick Kossifidis @ 2008-07-28 13:04 UTC (permalink / raw)
To: Jiri Slaby; +Cc: ath5k-devel, linux-wireless, linville, mcgrof
2008/7/22 Jiri Slaby <jirislaby@gmail.com>:
> On 07/20/2008 05:52 AM, Nick Kossifidis wrote:
>> Last minute fix...
>>
>> AR5K_CPCORN is changed to AR5K_CPCOVF in reg list update so we have to update debug.c in order to compile
>>
>> Changes-licensed-under: ISC
>> Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
>>
>> ---
>> diff --git a/drivers/net/wireless/ath5k/debug.c b/drivers/net/wireless/ath5k/debug.c
>> index 41d5fa3..6fa6c8e 100644
>> --- a/drivers/net/wireless/ath5k/debug.c
>> +++ b/drivers/net/wireless/ath5k/debug.c
>> @@ -129,7 +129,7 @@ static struct reg regs[] = {
>> REG_STRUCT_INIT(AR5K_CPC1),
>> REG_STRUCT_INIT(AR5K_CPC2),
>> REG_STRUCT_INIT(AR5K_CPC3),
>> - REG_STRUCT_INIT(AR5K_CPCORN),
>> + REG_STRUCT_INIT(AR5K_CPCOVF),
>> REG_STRUCT_INIT(AR5K_RESET_CTL),
>> REG_STRUCT_INIT(AR5K_SLEEP_CTL),
>> REG_STRUCT_INIT(AR5K_INTPEND),
>
> Please amend this to the patch 1 to not break bisectability.
I see your point but this series is meant to be applied as a whole, i
didn't notice this bug until i tested the code with debugging enabled
(which is off by default), that's why it's "last minute fix". Is it
really that much needed to repost the first patch ? I mean the patch
series works and doesn't introduce any problems...
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ath5k-devel] [PATCH 12/12] ath5k: Fix a compilation error after reg list update
2008-07-28 13:04 ` [ath5k-devel] " Nick Kossifidis
@ 2008-07-28 13:10 ` Pavel Roskin
2008-07-28 14:44 ` Nick Kossifidis
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Roskin @ 2008-07-28 13:10 UTC (permalink / raw)
To: Nick Kossifidis; +Cc: Jiri Slaby, ath5k-devel, linux-wireless, linville, mcgrof
On Mon, 2008-07-28 at 16:04 +0300, Nick Kossifidis wrote:
> > Please amend this to the patch 1 to not break bisectability.
>
> I see your point but this series is meant to be applied as a whole, i
> didn't notice this bug until i tested the code with debugging enabled
> (which is off by default), that's why it's "last minute fix". Is it
> really that much needed to repost the first patch ? I mean the patch
> series works and doesn't introduce any problems...
The reason is that git-bisect divides the number of commits in half and
checks out the middle commit. That commit make be a broken one.
Hitting one bug while hunting another is not nice.
Besides, nobody wants to apply a known bad patch.
It would be great if you repost fixed patches. If you are not using
stgit, please try it. I would make it easy to return to older patches
and change them. "stg edit -d" even allows editing the patch.
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ath5k-devel] [PATCH 12/12] ath5k: Fix a compilation error after reg list update
2008-07-28 13:10 ` Pavel Roskin
@ 2008-07-28 14:44 ` Nick Kossifidis
0 siblings, 0 replies; 6+ messages in thread
From: Nick Kossifidis @ 2008-07-28 14:44 UTC (permalink / raw)
To: Pavel Roskin; +Cc: Jiri Slaby, ath5k-devel, linux-wireless, linville, mcgrof
2008/7/28 Pavel Roskin <proski@gnu.org>:
> On Mon, 2008-07-28 at 16:04 +0300, Nick Kossifidis wrote:
>
>> > Please amend this to the patch 1 to not break bisectability.
>>
>> I see your point but this series is meant to be applied as a whole, i
>> didn't notice this bug until i tested the code with debugging enabled
>> (which is off by default), that's why it's "last minute fix". Is it
>> really that much needed to repost the first patch ? I mean the patch
>> series works and doesn't introduce any problems...
>
> The reason is that git-bisect divides the number of commits in half and
> checks out the middle commit. That commit make be a broken one.
> Hitting one bug while hunting another is not nice.
>
> Besides, nobody wants to apply a known bad patch.
>
> It would be great if you repost fixed patches. If you are not using
> stgit, please try it. I would make it easy to return to older patches
> and change them. "stg edit -d" even allows editing the patch.
>
> --
> Regards,
> Pavel Roskin
>
O.K. then i'll repost the first patch asap (i'm still in Ottawa :P)...
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-07-28 14:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-20 3:52 [PATCH 12/12] ath5k: Fix a compilation error after reg list update Nick Kossifidis
2008-07-22 14:36 ` Jiri Slaby
2008-07-28 13:04 ` [ath5k-devel] " Nick Kossifidis
2008-07-28 13:10 ` Pavel Roskin
2008-07-28 14:44 ` Nick Kossifidis
2008-07-22 14:53 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).