linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	John Linville <linville@tuxdriver.com>
Subject: Re: mac80211 deadlock detection triggering with rt61pci
Date: Mon, 21 Jul 2008 15:05:31 +0200	[thread overview]
Message-ID: <200807211505.31571.IvDoorn@gmail.com> (raw)
In-Reply-To: <1216489342.29432.5.camel@johannes.berg>

On Saturday 19 July 2008, Johannes Berg wrote:
> On Sat, 2008-07-19 at 16:47 +0200, Ivo van Doorn wrote:
> > On Friday 18 July 2008, Ivo van Doorn wrote:
> 
> > It might be me, but looking at those traces, aren't they triggered by:
> > 
> > static int ieee80211_tx(struct net_device *dev, struct sk_buff *skb)
> > {
> > ...
> > 		if (WARN_ON(queue >= ieee80211_num_regular_queues(&local->hw)))
> > 			goto drop;
> > ...
> > }
> > 
> > Which would suggest that when MAC80211_QOS is disabled, the skb_queue_mapping
> > still returns something higher then 1.
> 
> Oh, interesting, could be, I'll check it out.

I think I was wrong, just received a report which indeed marked the line:
	if (WARN_ON_ONCE(retries > 5))

recent mac80211 patches had moved the WARN_ON line more then I thought. ;)

In any case, I am still not sure why this bug is being triggered, but I am following a lead
with the rt2x00 errors that come directly before the WARN_ON is being triggered.

Ivo

      reply	other threads:[~2008-07-21 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16  8:36 mac80211 deadlock detection triggering with rt61pci Johannes Berg
2008-07-18 19:20 ` Ivo van Doorn
2008-07-19 14:47   ` Ivo van Doorn
2008-07-19 17:42     ` Johannes Berg
2008-07-21 13:05       ` Ivo van Doorn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807211505.31571.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).