From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: leitao@linux.vnet.ibm.com, jirislaby@gmail.com,
netdev@vger.kernel.org, flamingice@sourmilk.net,
linux-wireless@vger.kernel.org
Subject: Re: q == &noop_qdisc warning from 802.11 code
Date: Wed, 23 Jul 2008 14:22:41 -0700 (PDT) [thread overview]
Message-ID: <20080723.142241.41151635.davem@davemloft.net> (raw)
In-Reply-To: <1216824786.13587.6.camel@johannes.berg>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 23 Jul 2008 16:53:05 +0200
>
> > I also hit a bug related to noop_qdisc running the net-next kernel.
> > I hit this bug every time I run "ifconfig eth0 mtu 9000; ifconfg eth0 1500" for any
> > interface (tested against s2io and e1000) that is up, otherwise the bug isn't
> > reproducible.
> >
> > The bug dumps the following calltrace:
> >
> > [root@io-dolphins net-next-2.6]# ifconfig eth0 mtu 9000; ifconfig eth0 mtu 1500
> > ------------[ cut here ]------------
> > kernel BUG at net/core/dev.c:1328!
>
> > void __netif_schedule(struct Qdisc *q)
> > {
> > BUG_ON(q == &noop_qdisc);
> >
> > So, somehow we're reaching __netif_schedule() using a noop_qdisc.
>
> Yeah, I'm looking into it. Just removing the netif_wake calls in mlme.c
> might work.
Don't work too hard on this now, I'm removing the warning as I mentioned
in a recent posting.
Most important is the bug where wireless expects the SKB control block
to be untouched across the qdisc layer, which was never true :-)
prev parent reply other threads:[~2008-07-23 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 12:28 q == &noop_qdisc warning from 802.11 code Jiri Slaby
2008-07-23 13:41 ` Breno Leitao
2008-07-23 14:53 ` Johannes Berg
2008-07-23 21:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080723.142241.41151635.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=flamingice@sourmilk.net \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=leitao@linux.vnet.ibm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).