From: "John W. Linville" <linville@tuxdriver.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>,
Dmitry Torokhov <dtor@mail.ru>
Subject: Re: [PATCH 5/6] rfkill: query EV_SW states when rfkill-input (re)?connects to a input device
Date: Tue, 29 Jul 2008 16:53:15 -0400 [thread overview]
Message-ID: <20080729205315.GB10188@tuxdriver.com> (raw)
In-Reply-To: <1216685902-9373-6-git-send-email-hmh@hmh.eng.br>
On Mon, Jul 21, 2008 at 09:18:21PM -0300, Henrique de Moraes Holschuh w=
rote:
> Every time a new input device that is capable of one of the rfkill EV=
_SW events
> (currently only SW_RFKILL_ALL) is connected to rfkill-input, we must =
check the
> states of the input EV_SW switches and take action. Otherwise, we wi=
ll ignore
> the initial switch state.
>=20
> We also need to re-check the states of the EV_SW switches after a dev=
ice that
> was under an exclusive grab is released back to us, since we got no i=
nput
> events from that device while it was grabbed.
>=20
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: Ivo van Doorn <IvDoorn@gmail.com>
> Cc: Dmitry Torokhov <dtor@mail.ru>
CC [M] net/rfkill/rfkill-input.o
net/rfkill/rfkill-input.c: In function =E2=80=98rfkill_start=E2=80=99:
net/rfkill/rfkill-input.c:201: warning: passing argument 2 of =E2=80=98=
constant_test_bit=E2=80=99 from incompatible pointer type
net/rfkill/rfkill-input.c:201: warning: passing argument 2 of =E2=80=98=
variable_test_bit=E2=80=99 from incompatible pointer type
net/rfkill/rfkill-input.c:202: warning: passing argument 2 of =E2=80=98=
constant_test_bit=E2=80=99 from incompatible pointer type
net/rfkill/rfkill-input.c:202: warning: passing argument 2 of =E2=80=98=
variable_test_bit=E2=80=99 from incompatible pointer type
net/rfkill/rfkill-input.c:203: warning: passing argument 2 of =E2=80=98=
constant_test_bit=E2=80=99 from incompatible pointer type
net/rfkill/rfkill-input.c:203: warning: passing argument 2 of =E2=80=98=
variable_test_bit=E2=80=99 from incompatible pointer type
Don't you need an index for those evbit, swbit, and sw arrays?
--=20
John W. Linville
linville@tuxdriver.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-07-30 0:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 0:18 [GIT PATCH] rfkill fixes, set 2, v2 Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 1/6] rfkill: document rfkill_force_state as required (v2) Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 2/6] rfkill: fix led-trigger unregister order in error unwind Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 3/6] rfkill: document the rfkill struct locking (v2) Henrique de Moraes Holschuh
2008-07-22 17:11 ` Ivo van Doorn
2008-07-22 0:18 ` [PATCH 4/6] rfkill: mutex fixes Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 5/6] rfkill: query EV_SW states when rfkill-input (re)?connects to a input device Henrique de Moraes Holschuh
2008-07-22 13:57 ` Dmitry Torokhov
2008-07-22 17:11 ` Ivo van Doorn
2008-07-29 20:53 ` John W. Linville [this message]
2008-07-30 1:30 ` Dmitry Torokhov
2008-07-30 3:39 ` Henrique de Moraes Holschuh
2008-07-30 4:07 ` Henrique de Moraes Holschuh
2008-07-31 13:53 ` [PATCH] " Henrique de Moraes Holschuh
2008-07-31 14:38 ` Ivo van Doorn
2008-07-31 14:22 ` Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 6/6] rfkill: yet more minor kernel-doc fixes Henrique de Moraes Holschuh
2008-07-22 17:11 ` Ivo van Doorn
2008-07-22 17:11 ` [GIT PATCH] rfkill fixes, set 2, v2 Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729205315.GB10188@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=dtor@mail.ru \
--cc=hmh@hmh.eng.br \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).