Fix iwlwifi compilation without CONFIG_IWLWIFI_DEBUG

Fix iwlwifi compilation without CONFIG_IWLWIFI_DEBUG

[Andreas Schwab]

drivers/net/wireless/iwlwifi/iwl-led.c: In function =E2=80=98iwl_led_br=
ightness_set=E2=80=99:
drivers/net/wireless/iwlwifi/iwl-led.c:198: error: =E2=80=98led_type_st=
r=E2=80=99 undeclared (first use in this function)
drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared ide=
ntifier is reported only once
drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it=
 appears in.)

Signed-off-by: Andreas Schwab <schwab@suse.de>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wirel=
ess/iwlwifi/iwl-led.c
index 899d7a2..a58571c 100644
--- a/drivers/net/wireless/iwlwifi/iwl-led.c
+++ b/drivers/net/wireless/iwlwifi/iwl-led.c
@@ -195,8 +195,10 @@ static void iwl_led_brightness_set(struct led_clas=
sdev *led_cdev,
 		return;
=20
=20
+#ifdef CONFIG_IWLWIFI_DEBUG
 	IWL_DEBUG_LED("Led type =3D %s brightness =3D %d\n",
 			led_type_str[led->type], brightness);
+#endif
 	switch (brightness) {
 	case LED_FULL:
 		if (led->type =3D=3D IWL_LED_TRG_ASSOC)

--=20
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstra=C3=9Fe 5, 90409 N=C3=BCrnberg, Ge=
rmany
PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4=
ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Fix iwlwifi compilation without CONFIG_IWLWIFI_DEBUG

[Tomas Winkler]

On Tue, Jul 29, 2008 at 10:03 PM, Andreas Schwab <schwab@suse.de> wrote:
> drivers/net/wireless/iwlwifi/iwl-led.c: In function 'iwl_led_brightness_set':
> drivers/net/wireless/iwlwifi/iwl-led.c:198: error: 'led_type_str' undeclared (first use in this function)
> drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared identifier is reported only once
> drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it appears in.)
>
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> ---
> diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wireless/iwlwifi/iwl-led.c
> index 899d7a2..a58571c 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-led.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-led.c
> @@ -195,8 +195,10 @@ static void iwl_led_brightness_set(struct led_classdev *led_cdev,
>                return;
>
>
> +#ifdef CONFIG_IWLWIFI_DEBUG
>        IWL_DEBUG_LED("Led type = %s brightness = %d\n",
>                        led_type_str[led->type], brightness);
> +#endif
>        switch (brightness) {
>        case LED_FULL:
>                if (led->type == IWL_LED_TRG_ASSOC)
>

Thanks for your patch
But the fixes were already sent out  a week ago or You can find them
on this mailing list.
Tomas

Re: Fix iwlwifi compilation without CONFIG_IWLWIFI_DEBUG

[Randy Dunlap]

On Tue, 29 Jul 2008 23:50:25 +0300 Tomas Winkler wrote:

> On Tue, Jul 29, 2008 at 10:03 PM, Andreas Schwab <schwab@suse.de> wrote:
> > drivers/net/wireless/iwlwifi/iwl-led.c: In function 'iwl_led_brightness_set':
> > drivers/net/wireless/iwlwifi/iwl-led.c:198: error: 'led_type_str' undeclared (first use in this function)
> > drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared identifier is reported only once
> > drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it appears in.)
> >
> > Signed-off-by: Andreas Schwab <schwab@suse.de>
> > ---
> > diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wireless/iwlwifi/iwl-led.c
> > index 899d7a2..a58571c 100644
> > --- a/drivers/net/wireless/iwlwifi/iwl-led.c
> > +++ b/drivers/net/wireless/iwlwifi/iwl-led.c
> > @@ -195,8 +195,10 @@ static void iwl_led_brightness_set(struct led_classdev *led_cdev,
> >                return;
> >
> >
> > +#ifdef CONFIG_IWLWIFI_DEBUG
> >        IWL_DEBUG_LED("Led type = %s brightness = %d\n",
> >                        led_type_str[led->type], brightness);
> > +#endif
> >        switch (brightness) {
> >        case LED_FULL:
> >                if (led->type == IWL_LED_TRG_ASSOC)
> >
> 
> Thanks for your patch
> But the fixes were already sent out  a week ago or You can find them
> on this mailing list.

But the reason that we are seeing this (third IIRC) patch for this problem
is that the patch needs to be merged somewhere..... :(
other than the mailing list.


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Re: Fix iwlwifi compilation without CONFIG_IWLWIFI_DEBUG

[Tomas Winkler]

On Tue, Jul 29, 2008 at 11:55 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Tue, 29 Jul 2008 23:50:25 +0300 Tomas Winkler wrote:
>
>> On Tue, Jul 29, 2008 at 10:03 PM, Andreas Schwab <schwab@suse.de> wrote:
>> > drivers/net/wireless/iwlwifi/iwl-led.c: In function 'iwl_led_brightness_set':
>> > drivers/net/wireless/iwlwifi/iwl-led.c:198: error: 'led_type_str' undeclared (first use in this function)
>> > drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared identifier is reported only once
>> > drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it appears in.)
>> >
>> > Signed-off-by: Andreas Schwab <schwab@suse.de>
>> > ---
>> > diff --git a/drivers/net/wireless/iwlwifi/iwl-led.c b/drivers/net/wireless/iwlwifi/iwl-led.c
>> > index 899d7a2..a58571c 100644
>> > --- a/drivers/net/wireless/iwlwifi/iwl-led.c
>> > +++ b/drivers/net/wireless/iwlwifi/iwl-led.c
>> > @@ -195,8 +195,10 @@ static void iwl_led_brightness_set(struct led_classdev *led_cdev,
>> >                return;
>> >
>> >
>> > +#ifdef CONFIG_IWLWIFI_DEBUG
>> >        IWL_DEBUG_LED("Led type = %s brightness = %d\n",
>> >                        led_type_str[led->type], brightness);
>> > +#endif
>> >        switch (brightness) {
>> >        case LED_FULL:
>> >                if (led->type == IWL_LED_TRG_ASSOC)
>> >
>>
>> Thanks for your patch
>> But the fixes were already sent out  a week ago or You can find them
>> on this mailing list.
>
> But the reason that we are seeing this (third IIRC) patch for this problem
> is that the patch needs to be merged somewhere..... :(
> other than the mailing list.

Definitely. John Linville was also on OLS I guess that's the reason
for delay in merge.  I've even reposed this patches to LKML IRCC to
Andrew Morton's request
What more can I do.  Maybe David Miller can somehow speed up the
process not sure.
But this is like 5th patch I've received to fix this starting to be a
bit annoying.

BTW 'Denis V. Lunev' is the author of the 3 patches that fixes this
http://marc.info/?l=linux-wireless&m=121642949226032&w=2
http://marc.info/?l=linux-wireless&m=121636411821968&w=2
http://marc.info/?l=linux-wireless&m=121629329109400&w=2

Tomas.

Re: Fix iwlwifi compilation without CONFIG_IWLWIFI_DEBUG

[John W. Linville]

On Wed, Jul 30, 2008 at 12:11:47AM +0300, Tomas Winkler wrote:

> Definitely. John Linville was also on OLS I guess that's the reason
> for delay in merge.  I've even reposed this patches to LKML IRCC to
> Andrew Morton's request
> What more can I do.  Maybe David Miller can somehow speed up the
> process not sure.
> But this is like 5th patch I've received to fix this starting to be a
> bit annoying.
> 
> BTW 'Denis V. Lunev' is the author of the 3 patches that fixes this
> http://marc.info/?l=linux-wireless&m=121642949226032&w=2
> http://marc.info/?l=linux-wireless&m=121636411821968&w=2
> http://marc.info/?l=linux-wireless&m=121629329109400&w=2

Hold your wedgie, the patches are in flight...

-- 
John W. Linville
linville@tuxdriver.com